bakerface/fluent-dynamo

View on GitHub

Showing 6 of 6 total issues

File fluent.js has 373 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Copyright (c) 2015 Christopher M. Baker
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
Severity: Minor
Found in lib/fluent.js - About 4 hrs to fix

    Function withCondition has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function withCondition(request, name) {
      function isOperation(operator, type, value) {
        var key = ':v' + Object.keys(request.ExpressionAttributeValues).length;
        var attribute = request.ExpressionAttributeValues[key] = { };
        attribute[type] = value.toString();
    Severity: Minor
    Found in lib/fluent.js - About 1 hr to fix

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

        return {
          asType: asType.bind(this),
          asString: asType.bind(this, 'S'),
          asNumber: asType.bind(this, 'N')
        };
      Severity: Major
      Found in lib/fluent.js and 3 other locations - About 30 mins to fix
      lib/fluent.js on lines 383..387
      lib/fluent.js on lines 427..431
      lib/fluent.js on lines 705..709

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

        return {
          withProjection: project.bind(this),
          withAllAttributesProjection: project.bind(this, 'ALL'),
          withKeysOnlyProjection: project.bind(this, 'KEYS_ONLY')
        };
      Severity: Major
      Found in lib/fluent.js and 3 other locations - About 30 mins to fix
      lib/fluent.js on lines 255..259
      lib/fluent.js on lines 427..431
      lib/fluent.js on lines 705..709

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

        return {
          asValue: asValue.bind(this),
          asString: asValue.bind(this, 'S'),
          asNumber: asValue.bind(this, 'N')
        };
      Severity: Major
      Found in lib/fluent.js and 3 other locations - About 30 mins to fix
      lib/fluent.js on lines 255..259
      lib/fluent.js on lines 383..387
      lib/fluent.js on lines 705..709

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

        return {
          asValue: asValue.bind(this),
          asString: asValue.bind(this, 'S'),
          asNumber: asValue.bind(this, 'N')
        };
      Severity: Major
      Found in lib/fluent.js and 3 other locations - About 30 mins to fix
      lib/fluent.js on lines 255..259
      lib/fluent.js on lines 383..387
      lib/fluent.js on lines 427..431

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language