Sign upLogin

balanced/balanced-dashboard

View on GitHub
Star
app/models/core/model.js

Summary

Maintainability
D
2 days
Test Coverage

File model.js has 413 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import Ember from "ember";
import LoadPromise from "./mixins/load-promise";
import TypeMappings from "./type-mappings";
import Computed from "balanced-dashboard/utils/computed";
import Rev1Serializer from "balanced-dashboard/serializers/rev1";
Severity: Minor
Found in app/models/core/model.js - About 5 hrs to fix

    Function _handleError has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        _handleError: function(jqXHR, textStatus, errorThrown) {
        this.set('isSaving', false);

        if (jqXHR.status >= 400 && jqXHR.status < 500) {
            this.set('isValid', false);
    Severity: Minor
    Found in app/models/core/model.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _handleError has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        _handleError: function(jqXHR, textStatus, errorThrown) {
        this.set('isSaving', false);

        if (jqXHR.status >= 400 && jqXHR.status < 500) {
            this.set('isValid', false);
    Severity: Minor
    Found in app/models/core/model.js - About 1 hr to fix

      Function validateAndSave has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          validateAndSave: function(settings) {
        this.get("validationErrors").clear();
        this.validate();
        if (this.get("isValid")) {
            var Adapter = this.constructor.getAdapter();
      Severity: Minor
      Found in app/models/core/model.js - About 1 hr to fix

        Function belongsTo has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            belongsTo: function(propertyName, defaultType) {
        defaultType = defaultType || 'model';

        var embeddedProperty = JSON_PROPERTY_KEY + '.' + propertyName;
        var uriProperty = propertyName + URI_POSTFIX;
        Severity: Minor
        Found in app/models/core/model.js - About 1 hr to fix

          Function validateAndSave has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              validateAndSave: function(settings) {
        this.get("validationErrors").clear();
        this.validate();
        if (this.get("isValid")) {
            var Adapter = this.constructor.getAdapter();
          Severity: Minor
          Found in app/models/core/model.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _materializeLoadedObjectFromAPIResult has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              _materializeLoadedObjectFromAPIResult: function(json) {
        var UserMarketplace = require("balanced-dashboard/models/user-marketplace")['default'];
        var UserInvite = require("balanced-dashboard/models/user-invite")['default'];

        var objClass = this;
          Severity: Minor
          Found in app/models/core/model.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (jqXHR.status >= 400 && jqXHR.status < 500) {
            this.set('isValid', false);
            this.trigger('becameInvalid', jqXHR.responseJSON || jqXHR.responseText);
        } else {
            this.setProperties({
          Severity: Major
          Found in app/models/core/model.js and 1 other location - About 4 hrs to fix
          app/models/verification.js on lines 11..20

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 117.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  this
            .getAdapter()
            .get(modelClass, uri, function(json) {
                var object = modelClass.create({
                    uri: uri,
          Severity: Major
          Found in app/models/core/model.js and 1 other location - About 3 hrs to fix
          app/models/card.js on lines 169..181

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 102.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              isEqual: function(a, b) {
        b = b || this;
        return Ember.get(a, 'id') === Ember.get(b, 'id');
    }
          Severity: Minor
          Found in app/models/core/model.js and 1 other location - About 40 mins to fix
          app/models/user-marketplace.js on lines 24..27

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status