Sign upLogin

balazsgrill/wscgo

View on GitHub
Star

Showing 5 of 8 total issues

Method shutter.setCmd has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
Open

func (shutter *shutter) setCmd(steps int, stopIfDirchange bool) {
    shutter.lock.Lock()
    defer shutter.lock.Unlock()
    if steps == 0 {
        //stop
Severity: Minor
Found in devices/shutter.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method mcp23xxxConfigParser.ParseConfiguration has 10 return statements (exceeds 4 allowed).
Open

func (p *mcp23xxxConfigParser) ParseConfiguration(section config.ConfigurationSection, context config.ConfigurationContext) error {
    c := &Mcp23xxxConfig{}
    err := section.FillData(c)
    if err != nil {
        return err
Severity: Major
Found in integration/mcp23xxx.go - About 1 hr to fix

Method pca9685ConfigParser.ParseConfiguration has 6 return statements (exceeds 4 allowed).
Open

func (*pca9685ConfigParser) ParseConfiguration(section config.ConfigurationSection, context config.ConfigurationContext) error {
    c := &Pca9685Config{}
    err := section.FillData(c)
    if err != nil {
        return err
Severity: Major
Found in integration/pca9685.go - About 40 mins to fix

Function Dial has 6 return statements (exceeds 4 allowed).
Open

func Dial(address string) (*Client, error) {
    bt := GetCBContext()
    ctx, cancel := context.WithTimeout(context.Background(), timeout)
    defer cancel()
    client, err := ble.Dial(ctx, ble.NewAddr(address))
Severity: Major
Found in devices/cometblue/cometblue.go - About 40 mins to fix

Method CometBlueContext.init has 6 return statements (exceeds 4 allowed).
Open

func (c *CometBlueContext) init() error {
    var err error
    c.once.Do(func() {
        log.Println("Initializing bluetooth")
        d, err := dev.NewDevice("default")
Severity: Major
Found in devices/cometblue/bt.go - About 40 mins to fix
Severity
Category
Status
Source
Language