Sign upLogin

balderdashy/waterline

View on GitHub
Star

Showing 357 of 357 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

          if (_.has(Object.getPrototypeOf(WLChild), 'junctionTable') && WLChild.junctionTable) {

            // Assumes the generated junction table will only ever have two foreign key
            // values. Should be safe for now and any changes would need to be made in
            // Waterline-Schema where a map could be formed anyway.
Severity: Major
Found in lib/waterline/methods/remove-from-collection.js and 1 other location - About 1 day to fix
lib/waterline/methods/replace-collection.js on lines 342..366

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 245.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function replaceCollection has 241 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function replaceCollection(/* targetRecordIds?, collectionAttrName?, associatedIds?, explicitCbMaybe?, meta? */) {

  // Verify `this` refers to an actual Sails/Waterline model.
  verifyModelMethodContext(this);
Severity: Major
Found in lib/waterline/methods/replace-collection.js - About 1 day to fix

    Function destroy has 233 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function destroy(/* criteria, explicitCbMaybe, metaContainer */) {

  // Verify `this` refers to an actual Sails/Waterline model.
  verifyModelMethodContext(this);
    Severity: Major
    Found in lib/waterline/methods/destroy.js - About 1 day to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        (function _handleVariadicUsage(){

    // The metadata container, if one was provided.
    var _meta;
      Severity: Major
      Found in lib/waterline/methods/replace-collection.js and 2 other locations - About 1 day to fix
      lib/waterline/methods/add-to-collection.js on lines 119..153
      lib/waterline/methods/remove-from-collection.js on lines 122..156

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 221.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        (function _handleVariadicUsage(){

    // The metadata container, if one was provided.
    var _meta;
      Severity: Major
      Found in lib/waterline/methods/remove-from-collection.js and 2 other locations - About 1 day to fix
      lib/waterline/methods/add-to-collection.js on lines 119..153
      lib/waterline/methods/replace-collection.js on lines 118..152

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 221.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        (function _handleVariadicUsage(){

    // The metadata container, if one was provided.
    var _meta;
      Severity: Major
      Found in lib/waterline/methods/add-to-collection.js and 2 other locations - About 1 day to fix
      lib/waterline/methods/remove-from-collection.js on lines 122..156
      lib/waterline/methods/replace-collection.js on lines 118..152

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 221.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          if (!_.isUndefined(s3Q.criteria.sort) && s3Q.criteria.sort.length) {
      s3Q.criteria.sort = _.map(s3Q.criteria.sort, function(sortClause) {
        var comparatorTarget = _.first(_.keys(sortClause));
        var attrName = _.first(comparatorTarget.split(/\./));
        var sortDirection = sortClause[comparatorTarget];
      Severity: Major
      Found in lib/waterline/utils/query/forge-stage-three-query.js and 1 other location - About 1 day to fix
      lib/waterline/utils/query/forge-stage-three-query.js on lines 253..264

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 220.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          if (!_.isUndefined(s3Q.criteria.sort) && s3Q.criteria.sort.length) {
      s3Q.criteria.sort = _.map(s3Q.criteria.sort, function(sortClause) {
        var comparatorTarget = _.first(_.keys(sortClause));
        var attrName = _.first(comparatorTarget.split(/\./));
        var sortDirection = sortClause[comparatorTarget];
      Severity: Major
      Found in lib/waterline/utils/query/forge-stage-three-query.js and 1 other location - About 1 day to fix
      lib/waterline/utils/query/forge-stage-three-query.js on lines 199..210

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 220.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function processAllRecords has 227 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function processAllRecords(records, meta, modelIdentity, orm) {
  // console.time('processAllRecords');


  if (!_.isArray(records)) {
      Severity: Major
      Found in lib/waterline/utils/query/process-all-records.js - About 1 day to fix

        Function _getPopulatedRecords has 220 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          (function _getPopulatedRecords(proceed){

    //  ┌┬┐┌─┐  ┬ ┬┌─┐  ┌┐┌┌─┐┌─┐┌┬┐  ┌─┐┬ ┬┬┌┬┐┌─┐
    //   │││ │  │││├┤   │││├┤ ├┤  ││  └─┐├─┤││││ ┌┘
    //  ─┴┘└─┘  └┴┘└─┘  ┘└┘└─┘└─┘─┴┘  └─┘┴ ┴┴┴ ┴ o
        Severity: Major
        Found in lib/waterline/utils/query/help-find.js - About 1 day to fix

          Function _eachParentOrChildRecord has 215 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            eachRecordDeep(records, function _eachParentOrChildRecord(record, WLModel){

    // First, check the results to verify compliance with the adapter spec.,
    // as well as any issues related to stale data that might not have been
    // been migrated to keep up with the logical schema (`type`, etc. in
          Severity: Major
          Found in lib/waterline/utils/query/process-all-records.js - About 1 day to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              if (!_.isUndefined(criteria.max)) {
    throw new Error(
      'The `max` clause is no longer supported in Sails/Waterline.\n'+
      'In previous versions, `max` could be provided in a criteria '+
      'to perform an aggregation query.  But as of Sails v1.0/Waterline v0.13, the '+
            Severity: Major
            Found in lib/waterline/utils/query/private/normalize-criteria.js and 1 other location - About 1 day to fix
            lib/waterline/utils/query/private/normalize-criteria.js on lines 305..340

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 207.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              if (!_.isUndefined(criteria.min)) {
    throw new Error(
      'The `min` clause is no longer supported in Sails/Waterline.\n'+
      'In previous versions, `min` could be provided in a criteria '+
      'to perform an aggregation query.  But as of Sails v1.0/Waterline v0.13, the '+
            Severity: Major
            Found in lib/waterline/utils/query/private/normalize-criteria.js and 1 other location - About 1 day to fix
            lib/waterline/utils/query/private/normalize-criteria.js on lines 342..377

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 207.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function getAttribute has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring.
            Open

            module.exports = function getAttribute(attrName, modelIdentity, orm) {

  // ================================================================================================
  // Check that the provided `attrName` is valid.
  // (`modelIdentity` and `orm` will be automatically checked by calling `getModel()`)
            Severity: Minor
            Found in lib/waterline/utils/ontology/get-attribute.js - About 1 day to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function normalizeWhereClause has a Cognitive Complexity of 54 (exceeds 5 allowed). Consider refactoring.
            Open

            module.exports = function normalizeWhereClause(whereClause, modelIdentity, orm, meta) {

  // Look up the Waterline model for this query.
  // > This is so that we can reference the original model definition.
  var WLModel = getModel(modelIdentity, orm);
            Severity: Minor
            Found in lib/waterline/utils/query/private/normalize-where-clause.js - About 1 day to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function normalizeSortClause has 208 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            module.exports = function normalizeSortClause(sortClause, modelIdentity, orm, meta) {

  // Look up the Waterline model for this query.
  // > This is so that we can reference the original model definition.
  var WLModel = getModel(modelIdentity, orm);
            Severity: Major
            Found in lib/waterline/utils/query/private/normalize-sort-clause.js - About 1 day to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                if (args.length >= 2 && _.isFunction(args[1])) {
    query.numericAttrName = args[0];
    explicitCbMaybe = args[1];
    query.meta = args[2];
    if (args[3]) { _.extend(query, args[3]); }
              Severity: Major
              Found in lib/waterline/methods/sum.js and 1 other location - About 1 day to fix
              lib/waterline/methods/avg.js on lines 125..138

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 196.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                if (args.length >= 2 && _.isFunction(args[1])) {
    query.numericAttrName = args[0];
    explicitCbMaybe = args[1];
    query.meta = args[2];
    if (args[3]) { _.extend(query, args[3]); }
              Severity: Major
              Found in lib/waterline/methods/avg.js and 1 other location - About 1 day to fix
              lib/waterline/methods/sum.js on lines 127..140

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 196.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function stream has 194 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              module.exports = function stream( /* criteria?, eachRecordFn?, explicitCbMaybe?, meta?, moreQueryKeys? */ ) {

  // Verify `this` refers to an actual Sails/Waterline model.
  verifyModelMethodContext(this);
              Severity: Major
              Found in lib/waterline/methods/stream.js - About 7 hrs to fix

                Function createEach has 191 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                module.exports = function createEach( /* newRecords?, explicitCbMaybe?, meta? */ ) {

  // Verify `this` refers to an actual Sails/Waterline model.
  verifyModelMethodContext(this);
                Severity: Major
                Found in lib/waterline/methods/create-each.js - About 7 hrs to fix
                  Severity
                  Category
                  Status
                  Source
                  Language