barbushin/php-imap

View on GitHub

Showing 41 of 41 total issues

File Mailbox.php has 1092 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace PhpImap;
Severity: Major
Found in src/PhpImap/Mailbox.php - About 2 days to fix

    Mailbox has 90 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Mailbox
    {
        public const EXPECTED_SIZE_OF_MESSAGE_AS_ARRAY = 2;
    
        public const MAX_LENGTH_FILEPATH = 255;
    Severity: Major
    Found in src/PhpImap/Mailbox.php - About 1 day to fix

      File Imap.php has 694 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
      /**
       * @author Barbushin Sergey http://linkedin.com/in/barbushin
       * @author BAPCLTD-Marv
       */
      Severity: Major
      Found in src/PhpImap/Imap.php - About 1 day to fix

        Function initMailPart has a Cognitive Complexity of 54 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function initMailPart(IncomingMail $mail, object $partStructure, $partNum, bool $markAsSeen = true, bool $emlParse = false): void
            {
                if (!isset($mail->id)) {
                    throw new InvalidArgumentException('Argument 1 passeed to '.__METHOD__.'() did not have the id property set!');
                }
        Severity: Minor
        Found in src/PhpImap/Mailbox.php - About 1 day to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getMailHeader has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getMailHeader(int $mailId): IncomingMailHeader
            {
                $headersRaw = Imap::fetchheader(
                    $this->getImapStream(),
                    $mailId,
        Severity: Minor
        Found in src/PhpImap/Mailbox.php - About 6 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Imap has 41 functions (exceeds 20 allowed). Consider refactoring.
        Open

        final class Imap
        {
            /** @psalm-var list<int> */
            public const SORT_CRITERIA = [
                SORTARRIVAL,
        Severity: Minor
        Found in src/PhpImap/Imap.php - About 5 hrs to fix

          Method getMailHeader has 123 lines of code (exceeds 40 allowed). Consider refactoring.
          Open

              public function getMailHeader(int $mailId): IncomingMailHeader
              {
                  $headersRaw = Imap::fetchheader(
                      $this->getImapStream(),
                      $mailId,
          Severity: Major
          Found in src/PhpImap/Mailbox.php - About 4 hrs to fix

            Function getMailsInfo has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getMailsInfo(array $mailsIds): array
                {
                    $mails = Imap::fetch_overview(
                        $this->getImapStream(),
                        \implode(',', $mailsIds),
            Severity: Minor
            Found in src/PhpImap/Mailbox.php - About 4 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method initMailPart has 95 lines of code (exceeds 40 allowed). Consider refactoring.
            Open

                protected function initMailPart(IncomingMail $mail, object $partStructure, $partNum, bool $markAsSeen = true, bool $emlParse = false): void
                {
                    if (!isset($mail->id)) {
                        throw new InvalidArgumentException('Argument 1 passeed to '.__METHOD__.'() did not have the id property set!');
                    }
            Severity: Major
            Found in src/PhpImap/Mailbox.php - About 3 hrs to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public static function mail_move(
                      $imap_stream,
                      $msglist,
                      string $mailbox,
                      int $options = 0
              Severity: Major
              Found in src/PhpImap/Imap.php and 1 other location - About 3 hrs to fix
              src/PhpImap/Imap.php on lines 592..617

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 143.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public static function mail_copy(
                      $imap_stream,
                      $msglist,
                      string $mailbox,
                      int $options = 0
              Severity: Major
              Found in src/PhpImap/Imap.php and 1 other location - About 3 hrs to fix
              src/PhpImap/Imap.php on lines 625..650

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 143.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function downloadAttachment has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function downloadAttachment(DataPartInfo $dataInfo, array $params, object $partStructure, bool $emlOrigin = false): IncomingMailAttachment
                  {
                      if ('RFC822' == $partStructure->subtype && isset($partStructure->disposition) && 'attachment' == $partStructure->disposition) {
                          $fileName = \strtolower($partStructure->subtype).'.eml';
                      } elseif ('ALTERNATIVE' == $partStructure->subtype) {
              Severity: Minor
              Found in src/PhpImap/Mailbox.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function embedImageAttachments has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function embedImageAttachments(): void
                  {
                      $fetchedHtml = $this->__get('textHtml');
              
                      \preg_match_all("/\bcid:[^'\"\s]{1,256}/mi", $fetchedHtml, $matches);
              Severity: Minor
              Found in src/PhpImap/IncomingMail.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method downloadAttachment has 64 lines of code (exceeds 40 allowed). Consider refactoring.
              Open

                  public function downloadAttachment(DataPartInfo $dataInfo, array $params, object $partStructure, bool $emlOrigin = false): IncomingMailAttachment
                  {
                      if ('RFC822' == $partStructure->subtype && isset($partStructure->disposition) && 'attachment' == $partStructure->disposition) {
                          $fileName = \strtolower($partStructure->subtype).'.eml';
                      } elseif ('ALTERNATIVE' == $partStructure->subtype) {
              Severity: Major
              Found in src/PhpImap/Mailbox.php - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public static function setflag_full(
                        $imap_stream,
                        $sequence,
                        string $flag,
                        int $options = NIL
                Severity: Major
                Found in src/PhpImap/Imap.php and 1 other location - About 1 hr to fix
                src/PhpImap/Imap.php on lines 156..181

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 117.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public static function clearflag_full(
                        $imap_stream,
                        $sequence,
                        string $flag,
                        int $options = 0
                Severity: Major
                Found in src/PhpImap/Imap.php and 1 other location - About 1 hr to fix
                src/PhpImap/Imap.php on lines 865..890

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 117.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function setConnectionArgs has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function setConnectionArgs(int $options = 0, int $retriesNum = 0, array $params = null): void
                    {
                        if (0 !== $options) {
                            if (($options & self::IMAP_OPTIONS_SUPPORTED_VALUES) !== $options) {
                                throw new InvalidParameterException('Please check your option for setConnectionArgs()! Unsupported option "'.$options.'". Available options: https://www.php.net/manual/de/function.imap-open.php');
                Severity: Minor
                Found in src/PhpImap/Mailbox.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function possiblyGetMailboxes has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function possiblyGetMailboxes(array $t): array
                    {
                        $arr = [];
                        if ($t) {
                            foreach ($t as $index => $item) {
                Severity: Minor
                Found in src/PhpImap/Mailbox.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public static function unsubscribe(
                        $imap_stream,
                        string $mailbox
                    ): void {
                        $imap_stream = self::EnsureConnection($imap_stream, __METHOD__, 1);
                Severity: Major
                Found in src/PhpImap/Imap.php and 1 other location - About 1 hr to fix
                src/PhpImap/Imap.php on lines 986..999

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 112.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public static function subscribe($imap_stream, string $mailbox): void
                    {
                        $imap_stream = self::EnsureConnection($imap_stream, __METHOD__, 1);
                
                        $mailbox = static::encodeStringToUtf7Imap($mailbox);
                Severity: Major
                Found in src/PhpImap/Imap.php and 1 other location - About 1 hr to fix
                src/PhpImap/Imap.php on lines 1030..1045

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 112.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Severity
                Category
                Status
                Source
                Language