Sign upLogin

barracudanetworks/jobrunner

View on GitHub
Star

Showing 63 of 63 total issues

Function canJobRun has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    protected function canJobRun($class)
    {
        $job_definition = $this->jobs[$class];
        if ($job_definition->getEnabled() == false)
        {
Severity: Minor
Found in src/JobRunner.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method canJobRun has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function canJobRun($class)
    {
        $job_definition = $this->jobs[$class];
        if ($job_definition->getEnabled() == false)
        {
Severity: Minor
Found in src/JobRunner.php - About 1 hr to fix

    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function __construct($class_name, $enabled = true, $run_time = null, $interval = 21600, $max_run_time = 172800)
    Severity: Minor
    Found in src/JobDefinition.php - About 35 mins to fix

      Missing function doc comment
      Open

          public function __construct(LoggerInterface $logger = null)
      Severity: Minor
      Found in examples/Complainer.php by phpcodesniffer

      Missing function doc comment
      Open

          public function getName();
      Severity: Minor
      Found in src/JobInterface.php by phpcodesniffer

      Missing class doc comment
      Open

      class JobRunner
      Severity: Minor
      Found in src/JobRunner.php by phpcodesniffer

      Expected 1 spaces after parameter type; 8 found
      Open

           * @param string        $class          The job that finished.
      Severity: Minor
      Found in src/JobRunner.php by phpcodesniffer

      Missing function doc comment
      Open

          public function prepareToFork();
      Severity: Minor
      Found in src/ForkingJobInterface.php by phpcodesniffer

      Missing parameter comment
      Open

           * @param int $lastRunTime
      Severity: Minor
      Found in src/Job.php by phpcodesniffer

      Missing parameter comment
      Open

           * @param int $lastRunTime
      Severity: Minor
      Found in src/Job.php by phpcodesniffer

      Missing @return tag in function comment
      Open

           */
      Severity: Minor
      Found in src/JobDefinition.php by phpcodesniffer

      Expected 1 spaces after parameter type; 2 found
      Open

           * @param JobDefinition  $definition Job definition (e.g. interval).
      Severity: Minor
      Found in src/JobRunner.php by phpcodesniffer

      Missing class doc comment
      Open

      abstract class ForkingJob extends Job implements ForkingJobInterface
      Severity: Minor
      Found in src/ForkingJob.php by phpcodesniffer

      Missing function doc comment
      Open

          public function getItemCount();
      Severity: Minor
      Found in src/ForkingJobInterface.php by phpcodesniffer

      Missing @return tag in function comment
      Open

           */
      Severity: Minor
      Found in src/JobDefinition.php by phpcodesniffer

      Missing function doc comment
      Open

          public function start();
      Severity: Minor
      Found in src/JobInterface.php by phpcodesniffer

      Missing file doc comment
      Open
      Severity: Minor
      Found in src/JobRunner.php by phpcodesniffer

      Missing class doc comment
      Open

      class ForkingComplimenter extends ForkingJob
      Severity: Minor
      Found in examples/ForkingComplimenter.php by phpcodesniffer

      Missing function doc comment
      Open

          public function getNumChildren();
      Severity: Minor
      Found in src/ForkingJobInterface.php by phpcodesniffer

      Missing @return tag in function comment
      Open

           */
      Severity: Minor
      Found in src/JobDefinition.php by phpcodesniffer
      Severity
      Category
      Status
      Source
      Language