Sign upLogin

basbeu/theSofties

View on GitHub
Star
app/src/androidTest/java/ch/epfl/sweng/favors/chat/ConversationTest.java

Summary

Maintainability
A
0 mins
Test Coverage

Method conversationTest has 274 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

    @Test
    public void conversationTest() {
        mActivityTestRule.launchActivity(null);

        try {
Severity: Major
Found in app/src/androidTest/java/ch/epfl/sweng/favors/chat/ConversationTest.java - About 1 day to fix

    File ConversationTest.java has 346 lines of code (exceeds 250 allowed). Consider refactoring.
    Wontfix

    package ch.epfl.sweng.favors.chat;


import android.support.test.espresso.ViewInteraction;
import android.support.test.filters.LargeTest;
    Severity: Minor
    Found in app/src/androidTest/java/ch/epfl/sweng/favors/chat/ConversationTest.java - About 4 hrs to fix

      Method conversationTest has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Wontfix

          @Test
    public void conversationTest() {
        mActivityTestRule.launchActivity(null);

        try {
      Severity: Minor
      Found in app/src/androidTest/java/ch/epfl/sweng/favors/chat/ConversationTest.java - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 5 locations. Consider refactoring.
      Wontfix

          private static Matcher<View> childAtPosition(
            final Matcher<View> parentMatcher, final int position) {

        return new TypeSafeMatcher<View>() {
            @Override
      Severity: Major
      Found in app/src/androidTest/java/ch/epfl/sweng/favors/chat/ConversationTest.java and 4 other locations - About 1 hr to fix
      app/src/androidTest/java/ch/epfl/sweng/favors/authentication/AuthenticationProcessTest.java on lines 125..142
      app/src/androidTest/java/ch/epfl/sweng/favors/main/AuthenticationUITest.java on lines 200..217
      app/src/androidTest/java/ch/epfl/sweng/favors/main/CompleteLoggedUITest.java on lines 1501..1518
      app/src/androidTest/java/ch/epfl/sweng/favors/main/LoggedInScreenTest.java on lines 128..145

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 81.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 7 locations. Consider refactoring.
      Wontfix

              ViewInteraction appCompatImageButton2 = onView(
                allOf(withContentDescription("Open navigation drawer"),
                        childAtPosition(
                                allOf(withId(R.id.toolbar),
                                        childAtPosition(
      Severity: Major
      Found in app/src/androidTest/java/ch/epfl/sweng/favors/chat/ConversationTest.java and 6 other locations - About 30 mins to fix
      app/src/androidTest/java/ch/epfl/sweng/favors/chat/ConversationTest.java on lines 73..81
      app/src/androidTest/java/ch/epfl/sweng/favors/main/CompleteLoggedUITest.java on lines 822..830
      app/src/androidTest/java/ch/epfl/sweng/favors/main/CompleteLoggedUITest.java on lines 950..958
      app/src/androidTest/java/ch/epfl/sweng/favors/main/CompleteLoggedUITest.java on lines 1103..1111
      app/src/androidTest/java/ch/epfl/sweng/favors/main/CompleteLoggedUITest.java on lines 1118..1126
      app/src/androidTest/java/ch/epfl/sweng/favors/main/CompleteLoggedUITest.java on lines 1425..1433

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 7 locations. Consider refactoring.
      Wontfix

              ViewInteraction appCompatImageButton = onView(
                allOf(withContentDescription("Open navigation drawer"),
                        childAtPosition(
                                allOf(withId(R.id.toolbar),
                                        childAtPosition(
      Severity: Major
      Found in app/src/androidTest/java/ch/epfl/sweng/favors/chat/ConversationTest.java and 6 other locations - About 30 mins to fix
      app/src/androidTest/java/ch/epfl/sweng/favors/chat/ConversationTest.java on lines 346..354
      app/src/androidTest/java/ch/epfl/sweng/favors/main/CompleteLoggedUITest.java on lines 822..830
      app/src/androidTest/java/ch/epfl/sweng/favors/main/CompleteLoggedUITest.java on lines 950..958
      app/src/androidTest/java/ch/epfl/sweng/favors/main/CompleteLoggedUITest.java on lines 1103..1111
      app/src/androidTest/java/ch/epfl/sweng/favors/main/CompleteLoggedUITest.java on lines 1118..1126
      app/src/androidTest/java/ch/epfl/sweng/favors/main/CompleteLoggedUITest.java on lines 1425..1433

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status