Sign upLogin

basbeu/theSofties

View on GitHub
Star
app/src/main/java/ch/epfl/sweng/favors/database/Database.java

Summary

Maintainability
A
0 mins
Test Coverage

Method getList has 9 arguments (exceeds 4 allowed). Consider refactoring.
Wontfix

    protected  abstract <T extends DatabaseEntity> void getList(ObservableArrayList<T> list, Class<T> clazz,
                                                                String collection,
                                                                Map<DatabaseField, Object> mapEquals,
                                                                Map<DatabaseField, Object> mapLess,
                                                                Map<DatabaseField, Object> mapMore,
Severity: Major
Found in app/src/main/java/ch/epfl/sweng/favors/database/Database.java - About 1 hr to fix

    Method getLiveList has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Wontfix

        protected  abstract <T extends DatabaseEntity> void getLiveList(ObservableArrayList<T> list, Class<T> clazz,
                                                                    String collection,
                                                                    DatabaseField element,
                                                                    Object value,
                                                                    Integer limit,
    Severity: Major
    Found in app/src/main/java/ch/epfl/sweng/favors/database/Database.java - About 50 mins to fix

      Method getList has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Wontfix

          protected  abstract <T extends DatabaseEntity> void getList(ObservableArrayList<T> list, Class<T> clazz,
                                                                String collection,
                                                                DatabaseField element,
                                                                Object value,
                                                                Integer limit,
      Severity: Major
      Found in app/src/main/java/ch/epfl/sweng/favors/database/Database.java - About 50 mins to fix

        Method getElement has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Wontfix

            protected abstract <T extends DatabaseEntity> void getElement(T toUpdate, Class<T> clazz, String collection,
                                                                  DatabaseField element, Object value);
        Severity: Minor
        Found in app/src/main/java/ch/epfl/sweng/favors/database/Database.java - About 35 mins to fix

          Method getAll has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Wontfix

              protected abstract <T extends DatabaseEntity> void getAll(ObservableArrayList<T> list, Class<T> clazz,
                                                              String collection,
                                                              Integer limit,
                                                              DatabaseField orderBy);
          Severity: Minor
          Found in app/src/main/java/ch/epfl/sweng/favors/database/Database.java - About 35 mins to fix

            Method getInstance has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Wontfix

                public static Database getInstance(){
        if(db == null){
            if(ExecutionMode.getInstance().isTest()){
                db = FakeDatabase.getInstance();
            }
            Severity: Minor
            Found in app/src/main/java/ch/epfl/sweng/favors/database/Database.java - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 4 locations. Consider refactoring.
            Wontfix

                public static Database getInstance(){
        if(db == null){
            if(ExecutionMode.getInstance().isTest()){
                db = FakeDatabase.getInstance();
            }
            Severity: Major
            Found in app/src/main/java/ch/epfl/sweng/favors/database/Database.java and 3 other locations - About 40 mins to fix
            app/src/main/java/ch/epfl/sweng/favors/authentication/Authentication.java on lines 15..26
            app/src/main/java/ch/epfl/sweng/favors/location/Location.java on lines 24..34
            app/src/main/java/ch/epfl/sweng/favors/utils/email/RetrofitDispatcher.java on lines 17..27

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status