File FakeDatabase.java
has 630 lines of code (exceeds 250 allowed). Consider refactoring. Wontfix
package ch.epfl.sweng.favors.database;
import android.app.Activity;
import android.os.Handler;
import android.os.HandlerThread;
Method createBasicDatabase
has 269 lines of code (exceeds 25 allowed). Consider refactoring. Wontfix
public void createBasicDatabase(){
getInstance().cleanUp();
User u0 = new User(FakeAuthentication.UID);
User u1 = new User("U1");
Method check
has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring. Wontfix
private boolean check(CheckType type, Map.Entry<DatabaseField, Object> entry, DatabaseEntity entity){
if(entry == null || entity == null) return false;
if(entry.getKey() instanceof DatabaseStringField) {
String temp = entity.get((DatabaseStringField) entry.getKey());
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
FakeDatabase
has 22 methods (exceeds 20 allowed). Consider refactoring. Wontfix
public class FakeDatabase extends Database{
public static final String LAST_FAVOR_TITLE = "Flash needs some help";
public static FakeDatabase db = null;
private HashMap<String, DatabaseEntity> database;
Method addExtraToDb
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Wontfix
public void addExtraToDb(){
Favor fNew = new Favor("newFavor");
Favor fNew2 = new Favor("newFavor2");
fNew.set(Favor.StringFields.ownerID, "U3");
Method check
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Wontfix
private boolean check(CheckType type, Map.Entry<DatabaseField, Object> entry, DatabaseEntity entity){
if(entry == null || entity == null) return false;
if(entry.getKey() instanceof DatabaseStringField) {
String temp = entity.get((DatabaseStringField) entry.getKey());
Method getList
has 9 arguments (exceeds 4 allowed). Consider refactoring. Wontfix
protected <T extends DatabaseEntity> void getList(ObservableArrayList<T> list, Class<T> clazz,
String collection,
Map<DatabaseField, Object> mapEquals,
Map<DatabaseField, Object> mapLess,
Map<DatabaseField, Object> mapMore,
Method getLiveList
has 7 arguments (exceeds 4 allowed). Consider refactoring. Wontfix
protected <T extends DatabaseEntity> void getLiveList(ObservableArrayList<T> list, Class<T> clazz,
String collection,
DatabaseField key,
Object value,
Integer limit,
Method getList
has 7 arguments (exceeds 4 allowed). Consider refactoring. Wontfix
protected <T extends DatabaseEntity> void getList(ObservableArrayList<T> list, Class<T> clazz,
String collection,
DatabaseField key,
Object value,
Integer limit,
Method getElement
has 5 arguments (exceeds 4 allowed). Consider refactoring. Wontfix
protected <T extends DatabaseEntity> void getElement(T toUpdate, Class<T> clazz, String collection,
DatabaseField key, Object value){
Method getAll
has 5 arguments (exceeds 4 allowed). Consider refactoring. Wontfix
protected <T extends DatabaseEntity> void getAll(ObservableArrayList<T> list, Class<T> clazz, String collection, Integer limit, DatabaseField orderBy) {
Method processMap
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Wontfix
private boolean processMap(Map<DatabaseField, Object> map, DatabaseEntity entity, Boolean toAdd, CheckType checkType) {
if (toAdd && map != null) {
for (Map.Entry<DatabaseField, Object> e : map.entrySet()) {
if (!check(checkType, e, entity)) {
toAdd = false;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Wontfix
if(type == CheckType.Greater) return out > 0;
Avoid too many return
statements within this method. Wontfix
if(temp == null || !(entry.getValue() instanceof Boolean)) return false;
Avoid too many return
statements within this method. Wontfix
if(temp == null || !(entry.getValue() instanceof Long)) return false;
Avoid too many return
statements within this method. Wontfix
if(type == CheckType.Greater) return temp < (long) entry.getValue();
Avoid too many return
statements within this method. Wontfix
if(type == CheckType.Less) return temp > (long) entry.getValue();
Avoid too many return
statements within this method. Wontfix
if(type == CheckType.Equal) return temp == (long) entry.getValue();
Avoid too many return
statements within this method. Wontfix
if(type == CheckType.Less) return out < 0;
Avoid too many return
statements within this method. Wontfix
if(type == CheckType.Equal) return temp.equals(entry.getValue());
Avoid too many return
statements within this method. Wontfix
return ((ArrayList<String>) temp).contains((String) entry.getValue());
Avoid too many return
statements within this method. Wontfix
if(temp == null || !(entry.getValue() instanceof String)) return false;
Avoid too many return
statements within this method. Wontfix
else return false; // Comparison of String have no meaning
Avoid too many return
statements within this method. Wontfix
if(!(entry.getValue() instanceof String)) return false;
Avoid too many return
statements within this method. Wontfix
return false;
Avoid too many return
statements within this method. Wontfix
else return false; // Comparison on boolean has no meaning
Avoid too many return
statements within this method. Wontfix
if(type == CheckType.Equal) return temp == (boolean) entry.getValue();
Identical blocks of code found in 2 locations. Consider refactoring. Wontfix
for(DatabaseEntity entity : database.values()) {
if (clazz.isInstance(entity) && value instanceof String && entity.get((DatabaseStringField) key).equals(value)) {
try {
T temp = clazz.newInstance();
temp.set(entity.documentID, entity.getEncapsulatedObjectOfMaps());
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 92.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Wontfix
for(DatabaseEntity entity : database.values()) {
if (clazz.isInstance(entity) && value instanceof String && entity.get((DatabaseStringField) key).equals(value)) {
try {
T temp = clazz.newInstance();
temp.set(entity.documentID, entity.getEncapsulatedObjectOfMaps());
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 92.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76