Sign upLogin

basbeu/theSofties

View on GitHub
Star
app/src/main/java/ch/epfl/sweng/favors/database/FirebaseDatabase.java

Summary

Maintainability
A
0 mins
Test Coverage

Method onComplete has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Wontfix

        @Override
        public void onComplete(@NonNull Task task) {
            if (!task.isSuccessful()) {
                Log.d(TAG, "get failed with ", task.getException());
            }
Severity: Minor
Found in app/src/main/java/ch/epfl/sweng/favors/database/FirebaseDatabase.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getList has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Wontfix

    @Override
    protected  <T extends DatabaseEntity> void getList(ObservableArrayList<T> list, Class<T> clazz,
                                                       String collection,
                                                       Map<DatabaseField, Object> mapEquals,
                                                       Map<DatabaseField, Object> mapLess,
Severity: Minor
Found in app/src/main/java/ch/epfl/sweng/favors/database/FirebaseDatabase.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method onComplete has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

        @Override
        public void onComplete(@NonNull Task task) {
            if (!task.isSuccessful()) {
                Log.d(TAG, "get failed with ", task.getException());
            }
Severity: Minor
Found in app/src/main/java/ch/epfl/sweng/favors/database/FirebaseDatabase.java - About 1 hr to fix

    Method getList has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Wontfix

        protected  <T extends DatabaseEntity> void getList(ObservableArrayList<T> list, Class<T> clazz,
                                                       String collection,
                                                       Map<DatabaseField, Object> mapEquals,
                                                       Map<DatabaseField, Object> mapLess,
                                                       Map<DatabaseField, Object> mapMore,
    Severity: Major
    Found in app/src/main/java/ch/epfl/sweng/favors/database/FirebaseDatabase.java - About 1 hr to fix

      Method getList has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Wontfix

          protected <T extends DatabaseEntity> void getList(ObservableArrayList<T> list, Class<T> clazz,
                                                      String collection,
                                                      DatabaseField element,
                                                      Object value,
                                                      Integer limit,
      Severity: Major
      Found in app/src/main/java/ch/epfl/sweng/favors/database/FirebaseDatabase.java - About 50 mins to fix

        Method getLiveList has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Wontfix

            protected <T extends DatabaseEntity> void getLiveList(ObservableArrayList<T> list, Class<T> clazz,
                                                          String collection,
                                                          DatabaseField element,
                                                          Object value,
                                                          Integer limit,
        Severity: Major
        Found in app/src/main/java/ch/epfl/sweng/favors/database/FirebaseDatabase.java - About 50 mins to fix

          Method getElement has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Wontfix

              protected  <T extends DatabaseEntity> void getElement(T toUpdate, Class<T> clazz, String collection,
                                                          DatabaseField element, Object value){
          Severity: Minor
          Found in app/src/main/java/ch/epfl/sweng/favors/database/FirebaseDatabase.java - About 35 mins to fix

            Method getAll has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Wontfix

                protected <T extends DatabaseEntity> void getAll(ObservableArrayList<T> list, Class<T> clazz,
                                                     String collection,
                                                     Integer limit,
                                                     DatabaseField orderBy){
            Severity: Minor
            Found in app/src/main/java/ch/epfl/sweng/favors/database/FirebaseDatabase.java - About 35 mins to fix

              Method addParametersToQuery has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Wontfix

                  Query addParametersToQuery(Query query, Integer limit, DatabaseField orderBy){
        if(orderBy != null){
            if(orderBy == Favor.ObjectFields.creationTimestamp){
                query = query.orderBy(orderBy.toString(), Query.Direction.DESCENDING);
            }
              Severity: Minor
              Found in app/src/main/java/ch/epfl/sweng/favors/database/FirebaseDatabase.java - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Wontfix

                                      if (list != null) {
                            T documentObject = clazz.newInstance();
                            documentObject.set(document.getId(), document.getData());
                            temp.add(documentObject);
                        }
              Severity: Minor
              Found in app/src/main/java/ch/epfl/sweng/favors/database/FirebaseDatabase.java and 1 other location - About 30 mins to fix
              app/src/main/java/ch/epfl/sweng/favors/database/FirebaseDatabase.java on lines 281..285

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 42.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Wontfix

                                  if (list != null) {
                        T documentObject = clazz.newInstance();
                        documentObject.set(document.getId(), document.getData());
                        temp.add(documentObject);
                    }
              Severity: Minor
              Found in app/src/main/java/ch/epfl/sweng/favors/database/FirebaseDatabase.java and 1 other location - About 30 mins to fix
              app/src/main/java/ch/epfl/sweng/favors/database/FirebaseDatabase.java on lines 176..180

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 42.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Wontfix

                      if(mapLess != null) for(Map.Entry<DatabaseField, Object> el : mapLess.entrySet()){
            query = query.whereLessThan(el.getKey().toString(), el.getValue());
        }
              Severity: Major
              Found in app/src/main/java/ch/epfl/sweng/favors/database/FirebaseDatabase.java and 3 other locations - About 30 mins to fix
              app/src/main/java/ch/epfl/sweng/favors/database/FirebaseDatabase.java on lines 232..234
              app/src/main/java/ch/epfl/sweng/favors/database/FirebaseDatabase.java on lines 238..240
              app/src/main/java/ch/epfl/sweng/favors/database/FirebaseDatabase.java on lines 241..243

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 40.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Wontfix

                      if(mapMore != null) for(Map.Entry<DatabaseField, Object> el : mapMore.entrySet()){
            query = query.whereGreaterThan(el.getKey().toString(), el.getValue());
        }
              Severity: Major
              Found in app/src/main/java/ch/epfl/sweng/favors/database/FirebaseDatabase.java and 3 other locations - About 30 mins to fix
              app/src/main/java/ch/epfl/sweng/favors/database/FirebaseDatabase.java on lines 232..234
              app/src/main/java/ch/epfl/sweng/favors/database/FirebaseDatabase.java on lines 235..237
              app/src/main/java/ch/epfl/sweng/favors/database/FirebaseDatabase.java on lines 241..243

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 40.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Wontfix

                      if(mapContains != null) for(Map.Entry<DatabaseField, Object> el : mapContains.entrySet()){
            query = query.whereArrayContains(el.getKey().toString(), el.getValue());
        }
              Severity: Major
              Found in app/src/main/java/ch/epfl/sweng/favors/database/FirebaseDatabase.java and 3 other locations - About 30 mins to fix
              app/src/main/java/ch/epfl/sweng/favors/database/FirebaseDatabase.java on lines 232..234
              app/src/main/java/ch/epfl/sweng/favors/database/FirebaseDatabase.java on lines 235..237
              app/src/main/java/ch/epfl/sweng/favors/database/FirebaseDatabase.java on lines 238..240

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 40.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Wontfix

                      if(mapEquals != null) for(Map.Entry<DatabaseField, Object> el : mapEquals.entrySet()){
            query = query.whereEqualTo(el.getKey().toString(), el.getValue());
        }
              Severity: Major
              Found in app/src/main/java/ch/epfl/sweng/favors/database/FirebaseDatabase.java and 3 other locations - About 30 mins to fix
              app/src/main/java/ch/epfl/sweng/favors/database/FirebaseDatabase.java on lines 235..237
              app/src/main/java/ch/epfl/sweng/favors/database/FirebaseDatabase.java on lines 238..240
              app/src/main/java/ch/epfl/sweng/favors/database/FirebaseDatabase.java on lines 241..243

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 40.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status