Sign upLogin

bashaus/gbtiles

View on GitHub
Star
lib/gbtiles/gbt/export/asm/channel.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method convert_effect has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

          def convert_effect
            if effect_number == 0x0 then
              return effect_arpeggio
            end
Severity: Minor
Found in lib/gbtiles/gbt/export/asm/channel.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

              return effect_speed
Severity: Major
Found in lib/gbtiles/gbt/export/asm/channel.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                  return effect_pan
    Severity: Major
    Found in lib/gbtiles/gbt/export/asm/channel.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                    return effect_cut_note
      Severity: Major
      Found in lib/gbtiles/gbt/export/asm/channel.rb - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status