Sign upLogin

batebates/sudoku

View on GitHub
Star
src/model/Generator.rb

Summary

Maintainability
C
1 day
Test Coverage

Class Generator has 29 methods (exceeds 20 allowed). Consider refactoring.
Open

class Generator

    @grid = []            #avec trou
    @gridPlayer = []    #completé par le jouer
    @gridCorrect = []    #sans trou
Severity: Minor
Found in src/model/Generator.rb - About 3 hrs to fix

Method initialize has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    def initialize(difficulty, grid_string = "")
        puts "Generating new sudoku..."
        # Either take a pre-created puzzle, or create a new one programmatically

        random = Random.new
Severity: Minor
Found in src/model/Generator.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method solve! has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    def solve!
        unchanged = false
        imin = nil
        pmin = []
        min = 10
Severity: Minor
Found in src/model/Generator.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method solve! has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def solve!
        unchanged = false
        imin = nil
        pmin = []
        min = 10
Severity: Minor
Found in src/model/Generator.rb - About 1 hr to fix

Method initialize has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def initialize(difficulty, grid_string = "")
        puts "Generating new sudoku..."
        # Either take a pre-created puzzle, or create a new one programmatically

        random = Random.new
Severity: Minor
Found in src/model/Generator.rb - About 1 hr to fix

Method valid? has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def valid?()
        return false unless @grid

        return false unless @grid.length == 81
Severity: Minor
Found in src/model/Generator.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return !has_duplicates()
Severity: Major
Found in src/model/Generator.rb - About 30 mins to fix

There are no issues that match your filters.

Category
Status