Sign upLogin

batiste/django-page-cms

View on GitHub
Star
pages/views.py

Summary

Maintainability
B
5 hrs
Test Coverage

Function __call__ has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    def __call__(
            self, request, path=None, lang=None, delegation=True,
            **kwargs):

        current_page = False
Severity: Minor
Found in pages/views.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function resolve_page has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def resolve_page(self, request, context, is_staff):
        """Return the appropriate page according to the path."""
        path = context['path']
        lang = context['lang']
        page = Page.objects.from_path(
Severity: Minor
Found in pages/views.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __call__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __call__(
Severity: Minor
Found in pages/views.py - About 35 mins to fix

    Avoid too many return statements within this function.
    Open

                return context
    Severity: Major
    Found in pages/views.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return render(request, template_name, context)
      Severity: Major
      Found in pages/views.py - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status