baublet/w8mngr

View on GitHub
api/dataServices/createDataService.ts

Summary

Maintainability
D
1 day
Test Coverage

File createDataService.ts has 345 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { Knex } from "knex";
import omit from "lodash.omit";
import { ulid } from "ulid";

import { assertIsError } from "../../shared";
Severity: Minor
Found in api/dataServices/createDataService.ts - About 4 hrs to fix

    Function getUpsertBy has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function getUpsertBy<T extends QueryFactoryFunction>(
      queryFactory: T,
      entityName: string,
      idProp: string = "id"
    ) {
    Severity: Major
    Found in api/dataServices/createDataService.ts - About 2 hrs to fix

      Function getConnection has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function getConnection<T extends QueryFactoryFunction>(queryFactory: T) {
        return async <TEntity, TNode>(
          context: Context,
          input: {
            applyCustomConstraint?: (
      Severity: Minor
      Found in api/dataServices/createDataService.ts - About 1 hr to fix

        Function getUpsert has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function getUpsert<T extends QueryFactoryFunction>(
          queryFactory: T,
          entityName: string,
          idProp: string = "id"
        ) {
        Severity: Minor
        Found in api/dataServices/createDataService.ts - About 1 hr to fix

          Function payloads has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                items.map(async (item) => {
                  let insertOrUpdate: "INSERT" | "UPDATE" = "INSERT";
                  let id = "";
          
                  const query = getQuery();
          Severity: Minor
          Found in api/dataServices/createDataService.ts - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              return async (
                context: Context,
                where: WhereFunctionFromQueryFactory<T>
              ): Promise<EntityFromQueryFactoryFunction<T>[]> => {
                const getQuery = await queryFactory(context);
            Severity: Major
            Found in api/dataServices/createDataService.ts and 1 other location - About 1 hr to fix
            api/dataServices/createDataService.ts on lines 90..99

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              return async (
                context: Context,
                where: WhereFunctionFromQueryFactory<T>
              ): Promise<void> => {
                const getQuery = await queryFactory(context);
            Severity: Major
            Found in api/dataServices/createDataService.ts and 1 other location - About 1 hr to fix
            api/dataServices/createDataService.ts on lines 117..126

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status