Sign upLogin

baublet/w8mngr

View on GitHub
Star
client/components/Foods/AddableFoodMeasurements.tsx

Summary

Maintainability
F
3 days
Test Coverage

Function AddableFoodMeasurements has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
Open

export function AddableFoodMeasurements({
  food,
  saveSelectedFood,
}: {
  saveSelectedFood: (input: FoodLogInput) => void;
Severity: Minor
Found in client/components/Foods/AddableFoodMeasurements.tsx - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File AddableFoodMeasurements.tsx has 279 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import cx from "classnames";
import React from "react";

import { coalesce, or } from "../../../shared";
import { useForm, useKeyPressHandler } from "../../helpers";
Severity: Minor
Found in client/components/Foods/AddableFoodMeasurements.tsx - About 2 hrs to fix

    Function saveSelectedMeasurement has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        (event?: KeyboardEvent) => {
      if (!selectedMeasurement) {
        return;
      }
      if (event) {
    Severity: Minor
    Found in client/components/Foods/AddableFoodMeasurements.tsx - About 1 hr to fix

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

                        <div className="w-1/4 truncate" title="carbohydrates">
                    {getMeasurementWithMultiplier({
                      currentAmount: amountFormData.getValue("amount"),
                      measurementValue: or(selectedMeasurement.carbs, 0),
                      originalAmount: selectedMeasurement.amount,
      Severity: Major
      Found in client/components/Foods/AddableFoodMeasurements.tsx and 3 other locations - About 2 hrs to fix
      client/components/Foods/AddableFoodMeasurements.tsx on lines 225..232
      client/components/Foods/AddableFoodMeasurements.tsx on lines 233..240
      client/components/Foods/AddableFoodMeasurements.tsx on lines 249..256

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 80.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

                        <div className="w-1/4 truncate" title="calories">
                    {getMeasurementWithMultiplier({
                      currentAmount: amountFormData.getValue("amount"),
                      measurementValue: or(selectedMeasurement.calories, 0),
                      originalAmount: selectedMeasurement.amount,
      Severity: Major
      Found in client/components/Foods/AddableFoodMeasurements.tsx and 3 other locations - About 2 hrs to fix
      client/components/Foods/AddableFoodMeasurements.tsx on lines 233..240
      client/components/Foods/AddableFoodMeasurements.tsx on lines 241..248
      client/components/Foods/AddableFoodMeasurements.tsx on lines 249..256

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 80.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

                        <div className="w-1/4 truncate" title="fat">
                    {getMeasurementWithMultiplier({
                      currentAmount: amountFormData.getValue("amount"),
                      measurementValue: or(selectedMeasurement.fat, 0),
                      originalAmount: selectedMeasurement.amount,
      Severity: Major
      Found in client/components/Foods/AddableFoodMeasurements.tsx and 3 other locations - About 2 hrs to fix
      client/components/Foods/AddableFoodMeasurements.tsx on lines 225..232
      client/components/Foods/AddableFoodMeasurements.tsx on lines 241..248
      client/components/Foods/AddableFoodMeasurements.tsx on lines 249..256

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 80.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

                        <div className="w-1/4 truncate" title="protein">
                    {getMeasurementWithMultiplier({
                      currentAmount: amountFormData.getValue("amount"),
                      measurementValue: or(selectedMeasurement.protein, 0),
                      originalAmount: selectedMeasurement.amount,
      Severity: Major
      Found in client/components/Foods/AddableFoodMeasurements.tsx and 3 other locations - About 2 hrs to fix
      client/components/Foods/AddableFoodMeasurements.tsx on lines 225..232
      client/components/Foods/AddableFoodMeasurements.tsx on lines 233..240
      client/components/Foods/AddableFoodMeasurements.tsx on lines 241..248

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 80.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          measurements?: {
      edges: {
        node: {
          id: string;
          amount: number;
      Severity: Major
      Found in client/components/Foods/AddableFoodMeasurements.tsx and 1 other location - About 2 hrs to fix
      client/components/Foods/FoodListItem.tsx on lines 24..36

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 75.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                    <div>
                <PrimaryIconButton
                  title="Previous measurement"
                  disabled={!hasPrevious}
                  onClick={goToPrevious}
      Severity: Major
      Found in client/components/Foods/AddableFoodMeasurements.tsx and 1 other location - About 1 hr to fix
      client/components/Foods/AddableFoodMeasurements.tsx on lines 259..268

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 59.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                    <div>
                <PrimaryIconButton
                  title="Next measurement"
                  disabled={!hasNext}
                  onClick={goToNext}
      Severity: Major
      Found in client/components/Foods/AddableFoodMeasurements.tsx and 1 other location - About 1 hr to fix
      client/components/Foods/AddableFoodMeasurements.tsx on lines 199..208

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 59.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

      function TinyLabel({ children }: React.PropsWithChildren<{}>) {
  return <div className="lowercase text-slate-300">{children}</div>;
}
      Severity: Major
      Found in client/components/Foods/AddableFoodMeasurements.tsx and 3 other locations - About 50 mins to fix
      client/Application.tsx on lines 116..118
      client/pages/Nutrition.tsx on lines 71..73
      client/pages/UserPreferences.tsx on lines 298..300

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

              fat: measurementStringToNumberOrUndefined(
          getMeasurementWithMultiplier({
            currentAmount: amountFormData.getValue("amount"),
            measurementValue: or(selectedMeasurement.fat, 0),
            originalAmount: selectedMeasurement.amount,
      Severity: Major
      Found in client/components/Foods/AddableFoodMeasurements.tsx and 3 other locations - About 45 mins to fix
      client/components/Foods/AddableFoodMeasurements.tsx on lines 150..156
      client/components/Foods/AddableFoodMeasurements.tsx on lines 164..170
      client/components/Foods/AddableFoodMeasurements.tsx on lines 171..177

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

              calories: measurementStringToNumberOrUndefined(
          getMeasurementWithMultiplier({
            currentAmount: amountFormData.getValue("amount"),
            measurementValue: or(selectedMeasurement.calories, 0),
            originalAmount: selectedMeasurement.amount,
      Severity: Major
      Found in client/components/Foods/AddableFoodMeasurements.tsx and 3 other locations - About 45 mins to fix
      client/components/Foods/AddableFoodMeasurements.tsx on lines 157..163
      client/components/Foods/AddableFoodMeasurements.tsx on lines 164..170
      client/components/Foods/AddableFoodMeasurements.tsx on lines 171..177

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

              carbs: measurementStringToNumberOrUndefined(
          getMeasurementWithMultiplier({
            currentAmount: amountFormData.getValue("amount"),
            measurementValue: or(selectedMeasurement.carbs, 0),
            originalAmount: selectedMeasurement.amount,
      Severity: Major
      Found in client/components/Foods/AddableFoodMeasurements.tsx and 3 other locations - About 45 mins to fix
      client/components/Foods/AddableFoodMeasurements.tsx on lines 150..156
      client/components/Foods/AddableFoodMeasurements.tsx on lines 157..163
      client/components/Foods/AddableFoodMeasurements.tsx on lines 171..177

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

              protein: measurementStringToNumberOrUndefined(
          getMeasurementWithMultiplier({
            currentAmount: amountFormData.getValue("amount"),
            measurementValue: or(selectedMeasurement.protein, 0),
            originalAmount: selectedMeasurement.amount,
      Severity: Major
      Found in client/components/Foods/AddableFoodMeasurements.tsx and 3 other locations - About 45 mins to fix
      client/components/Foods/AddableFoodMeasurements.tsx on lines 150..156
      client/components/Foods/AddableFoodMeasurements.tsx on lines 157..163
      client/components/Foods/AddableFoodMeasurements.tsx on lines 164..170

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status