bbatsov/rubocop

View on GitHub
lib/rubocop/cop/style/symbol_proc.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method on_block has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

        def on_block(node)
          symbol_proc?(node) do |dispatch_node, arguments_node, method_name|
            if active_support_extensions_enabled?
              return if proc_node?(dispatch_node)
              return if LAMBDA_OR_PROC.include?(dispatch_node.method_name)
Severity: Minor
Found in lib/rubocop/cop/style/symbol_proc.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

            return if allowed_method_name?(dispatch_node.method_name)
Severity: Major
Found in lib/rubocop/cop/style/symbol_proc.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                return if node.block_type? && destructuring_block_argument?(arguments_node)
    Severity: Major
    Found in lib/rubocop/cop/style/symbol_proc.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return if allow_comments? && contains_comments?(node)
      Severity: Major
      Found in lib/rubocop/cop/style/symbol_proc.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return if allow_if_method_has_argument?(node.send_node)
        Severity: Major
        Found in lib/rubocop/cop/style/symbol_proc.rb - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status