Sign upLogin

bbc/flashheart

View on GitHub
Star

Showing 73 of 73 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  async post(uri: string, body: string, opts?: RequestOptions): Promise<Response> {
    return this.executor('post', ...arguments);
  }
Severity: Major
Found in src/circuitBreaker/circuitBreaker.ts and 2 other locations - About 50 mins to fix
src/circuitBreaker/circuitBreaker.ts on lines 71..73
src/circuitBreaker/circuitBreaker.ts on lines 79..81

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function configureClient has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

export function configureClient(params: ClientParams): httpTransport.HttpTransportClient {
  const transport = configureRequest(params);
  const builder = httpTransport
    .createBuilder(transport)
    .retries(getRetries(params))
Severity: Minor
Found in src/httpTransport/configuration.ts - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    events.on(`cache.${eventName}.timeout`, () => {
      client.increment(`${namespace}.${statName}.timeouts`);
    });
Severity: Minor
Found in src/httpTransport/configuration.ts and 1 other location - About 45 mins to fix
src/httpTransport/configuration.ts on lines 76..78

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function processExpressionObject has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

function processExpressionObject( val, key ) {
    var operator;
    if ( sys.isObject( val ) ) {
        var opKeys = Object.keys( val );
        var op = opKeys[ 0 ];
Severity: Minor
Found in docconfig/template/fixtures/documents/probe.js - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    events.on(`cache.${eventName}.error`, () => {
      client.increment(`${namespace}.${statName}.errors`);
    });
Severity: Minor
Found in src/httpTransport/configuration.ts and 1 other location - About 45 mins to fix
src/httpTransport/configuration.ts on lines 79..81

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function generate has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

function generate(type, title, docs, filename, resolveLinks) {
Severity: Minor
Found in docconfig/template/publish.js - About 35 mins to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      async delete(uri: string, opts?: RequestOptions): Promise<Response> {
    return this.executor('delete', ...arguments);
  }
    Severity: Minor
    Found in src/circuitBreaker/circuitBreaker.ts and 2 other locations - About 35 mins to fix
    src/circuitBreaker/circuitBreaker.ts on lines 67..69
    src/circuitBreaker/circuitBreaker.ts on lines 83..85

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      async head(uri: string, opts?: RequestOptions): Promise<Response> {
    return this.executor('head', ...arguments);
  }
    Severity: Minor
    Found in src/circuitBreaker/circuitBreaker.ts and 2 other locations - About 35 mins to fix
    src/circuitBreaker/circuitBreaker.ts on lines 67..69
    src/circuitBreaker/circuitBreaker.ts on lines 87..89

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      async get(uri: string, opts?: RequestOptions): Promise<Response> {
    return this.executor('get', ...arguments);
  }
    Severity: Minor
    Found in src/circuitBreaker/circuitBreaker.ts and 2 other locations - About 35 mins to fix
    src/circuitBreaker/circuitBreaker.ts on lines 83..85
    src/circuitBreaker/circuitBreaker.ts on lines 87..89

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid too many return statements within this function.
    Open

                            return parent[lastPart].shift();
    Severity: Major
    Found in docconfig/template/fixtures/documents/probe.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                          return parent[lastPart].push( newValue );
      Severity: Major
      Found in docconfig/template/fixtures/documents/probe.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                            return parent[lastPart];
        Severity: Major
        Found in docconfig/template/fixtures/documents/probe.js - About 30 mins to fix

          Function $elemMatch has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              $elemMatch : function ( qu, value ) {
        var expression, test, _i, _len;

        if ( sys.isArray( value ) ) {
            var _ref = qu.operands;
          Severity: Minor
          Found in docconfig/template/fixtures/documents/probe.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language