bbc/simorgh

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    <Grid
      dir={dir}
      columns={{
        group0: 6,
        group1: 6,

• Read up
  Read up

File mr.test.js has 451 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import moment from 'moment';
import './mr';

moment.locale('mr');

File index.test.jsx has 449 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import React from 'react';
import { renderRoutes, matchRoutes } from 'react-router-config';
import { MemoryRouter } from 'react-router-dom';

// test helpers

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    describe('Unknown error within the data fetch, react router or its dependencies', () => {
      const pageType = 'cpsAsset';

      beforeEach(() => {
        mockRouteProps({

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    describe('Unknown error within the data fetch, react router or its dependencies', () => {
      const pageType = 'articles';
      beforeEach(() => {
        mockRouteProps({
          id,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

const Fixture = ({ useLargeImages = false, timestamp = Date.now() }) => (
  <Promo>
    <Promo.Image
      useLargeImages={useLargeImages}
      src="https://ichef.test.bbci.co.uk/ace/ws/{width}/cpsdevpb/3502/test/0c533a40-770b-11ed-bd83-8f15ba358e41.jpg"

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

const FixtureWithWebp = ({
  useLargeImages = false,
  timestamp = Date.now(),
}) => (
  <Promo>

• Read up
  Read up

File index.test.jsx has 441 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/* eslint-disable jsx-a11y/click-events-have-key-events */
/* eslint-disable jsx-a11y/no-static-element-interactions */
import React from 'react';
import userEvent from '@testing-library/user-event';
import { waitFor } from '@testing-library/dom';

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    it('should call the view tracking hook with the correct params with multiple editorial onward journeys', () => {
      const viewTrackerSpy = jest.spyOn(viewTracking, 'default');
      render(
        <ScrollablePromo blocks={edOjA.model.blocks} blockGroupIndex={1} />,
      );

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

    it('should render a Facebook Post block and unmount correctly', () => {
      const { container, unmount } = render(
        <SocialEmbedContainer
          blocks={[facebookPostBlockEmbed]}
          source="https://www.facebook.com/RickAstley/posts/545713756920775"

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

    it('should render an Instagram block and unmount correctly', () => {
      const { container, unmount } = render(
        <SocialEmbedContainer
          blocks={[instagramBlock]}
          source="https://www.instagram.com/p/CgNAEjOK46_"

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    it('should call the view tracking hook with the correct params with multiple lists with at least one link', () => {
      const viewTrackerSpy = jest.spyOn(viewTracking, 'default');
      render(
        <BulletsWithContext
          blocks={listItemD.model.blocks}

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

    it('should render a Facebook Video block and unmount correctly', () => {
      const { container, unmount } = render(
        <SocialEmbedContainer
          blocks={[facebookVideoBlockEmbed]}
          source="https://www.facebook.com/RickAstley/videos/1378590239249667"

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    it('should call the click tracking hook with multiple editorial onward journeys', () => {
      const clickTrackerSpy = jest.spyOn(clickTracking, 'default');
      render(
        <ScrollablePromo blocks={edOjA.model.blocks} blockGroupIndex={1} />,
      );

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

    it('should render a Twitter block and unmount correctly', () => {
      const { container, unmount } = render(
        <SocialEmbedContainer
          blocks={[twitterBlock]}
          source="https://twitter.com/BBCNews/status/1384138850478346243?s=20"

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  11: {
    input: range(0, 11),
    expectedFirstSection: {
      firstRow: [0],
      regularRows: [

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  10: {
    input: range(0, 10),
    expectedFirstSection: {
      firstRow: [0],
      regularRows: [

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    describe('With no headline provided', () => {
      beforeEach(() => {
        delete cpsItem.headlines;
        delete assetTypeItem.name;
      });

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    describe('With no timestamp provided', () => {
      beforeEach(() => {
        delete cpsItem.timestamp;
        delete assetTypeItem.timestamp;
      });

• Read up
  Read up

File fixtureData.js has 438 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import { MEDIA_ASSET_PAGE, STORY_PAGE } from '#app/routes/utils/pageTypes';
import relItems from '../IndexAlsos/relatedItems';

export const completeItem = {
  headlines: {