bbc/simorgh

Identical blocks of code found in 3 locations. Consider refactoring.

Open

      <Grid
        dir={dir}
        columns={{
          group0: 6,
          group1: 6,

• Read up
  Read up

Similar blocks of code found in 21 locations. Consider refactoring.

Open

        <Grid
          dir={dir}
          item
          columns={{
            group0: 2,

• Read up
  Read up

Similar blocks of code found in 21 locations. Consider refactoring.

Open

        <Grid
          dir={dir}
          item
          columns={{
            group0: 2,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

          if (paragraphBlock) {
            const descriptionHtml = pathOr({}, ['text'], paragraphBlock);
            // strip html from the description, so we get description as plain text
            const elem = document.createElement('div');
            elem.innerHTML = descriptionHtml;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    const { getByText, container } = render(
      <ServiceContextProvider service="mundo">
        <CpsOnwardJourney
          labelId="heading-label"
          promoListComponent={promoListComponent}

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

          if (descriptionBlock) {
            const descriptionHtml = pathOr({}, ['text'], descriptionBlock);
            // strip html from the description, so we get description as plain text
            const elem = document.createElement('div');
            elem.innerHTML = descriptionHtml;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    const { getByText, container } = render(
      <ServiceContextProvider service="mundo">
        <CpsOnwardJourney
          labelId="heading-label"
          promoListComponent={promoListComponent}

• Read up
  Read up

File index.jsx has 262 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import React, { useContext } from 'react';
import styled from '@emotion/styled';
import GRID from '#psammead/psammead-grid/src';
import {
  GEL_GROUP_2_SCREEN_WIDTH_MAX,

File index.test.tsx has 262 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import React from 'react';
import { RequestContextProvider } from '../../contexts/RequestContext';
import { ToggleContextProvider } from '../../contexts/ToggleContext';
import { data as pidginMostReadData } from '../../../../data/pidgin/mostRead/index.json';
import serbianLatMostReadData from '../../../../data/serbian/mostRead/lat.json';

Function 372 has 57 lines of code (exceeds 25 allowed). Consider refactoring.

Open

            372: function(e) {
                "use strict";
                function t(e) {
                    return "function" == typeof e
                }

Function test has 57 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        it('should be displayed if the toggle is on, and shows the expected number of items', function test() {
          cy.fixture(`toggles/${service}.json`).then(toggles => {
            const recentEpisodesEnabled = path(
              ['recentVideoEpisodes', 'enabled'],
              toggles,

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  it('should return a variation of null when the client is ready but has timed out', () => {
    useDecisionSpy.mockReturnValue([{ variationKey: null }, true, true]);

    const { result } = renderHook(() =>
      useOptimizelyVariation('correct_experiment_id', {}, isClientSide),

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    const { container } = render(
      <Brand
        product="Default Brand Name"
        serviceLocalisedName="Service"
        svgHeight={24}

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

const getObserverInstance = element => {
  try {
    const [instance] = Array.from(observers).find(([, item]) =>
      item.elements.has(element),
    );

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  it('should return a variation of null when a decision is not made', () => {
    useDecisionSpy.mockReturnValue([{ variationKey: null }, true, false]);

    const { result } = renderHook(() =>
      useOptimizelyVariation('wrong_experiment_id', {}, isClientSide),

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

const getObserverInstance = element => {
  try {
    const [instance] = Array.from(observers).find(([, item]) =>
      item.elements.has(element),
    );

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

      const { container } = render(
        <Brand
          product="Default Brand Name"
          serviceLocalisedName="Service"
          svgHeight={24}

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  it('should return a variation of null when the client is not ready and not timed out', () => {
    useDecisionSpy.mockReturnValue([{ variationKey: null }, false, false]);

    const { result } = renderHook(() =>
      useOptimizelyVariation('correct_experiment_id', {}, isClientSide),

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  it(`should add mvt experiment header names to vary if they are enabled`, async () => {
    mockRouteProps({
      dataResponse: successDataResponse,
    });
    getMvtVaryHeaders.mockReturnValue('mvt-simorgh_dark_mode');

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  it(`should not add mvt experiment header names to vary if they are not enabled`, async () => {
    mockRouteProps({
      dataResponse: successDataResponse,
    });
    getMvtVaryHeaders.mockReturnValue('');

• Read up
  Read up