bbc/simorgh

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  it('should render podcast in a strong element', () => {
    const { getByText } = render(<PromoWithContext inline />);

    expect(getByText(brandTitle).closest('strong')).toBeInTheDocument();
  });

• Read up
  Read up

Function getAuthorTwitterHandle has 37 lines of code (exceeds 25 allowed). Consider refactoring.

Open

const getAuthorTwitterHandle = articleContentBlocks => {
  const [firstByline, ...otherBylines] = articleContentBlocks.filter(
    block => block.type === 'byline',
  );

Function handleFileChange has 37 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  const handleFileChange = (event: ChangeEvent<HTMLInputElement>) => {
    // Converts FileList to an actual array
    const chosenFiles = Array.prototype.slice.call(
      event.target.files,
    ) as File[];

Similar blocks of code found in 5 locations. Consider refactoring.

Open

    it('should render a Live TV bulletin correctly', () => {
      const { container } = render(
        <BulletinContainer item={liveTvBulletinItem} />,
        { service: 'igbo' },
      );

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

  it('should correctly render for 404', () => {
    const { container } = render(<ErrorPage errorCode={404} />, {
      service: 'news',
    });
    expect(container).toMatchSnapshot();

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    act(() => {
      triggerIntersection({
        changes: [{ isIntersecting: true }],
        observer: observerInstanceA,
      });

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

    it('should call fetch with the correct url when passed the pathname', async () => {
      await fetchPageData({ path: requestedPathname, pageType });

      expect(timeoutSpy).toHaveBeenCalledTimes(1);
      expect(fetch).toHaveBeenCalledWith(expectedUrl, fetchOptions);

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

    it('should call fetch on amp pages without .amp in pathname', async () => {
      await fetchPageData({ path: requestedPathname, pageType });

      expect(timeoutSpy).toHaveBeenCalledTimes(1);
      expect(fetch).toHaveBeenCalledWith(expectedUrl, fetchOptions);

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

    it('should render a TV bulletin with lang attribute', () => {
      const { container } = render(
        <BulletinContainer item={tvBulletinItem} />,
        { service: 'scotland' },
      );

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

    it('should render a Live Radio bulletin correctly', () => {
      const { container } = render(
        <BulletinContainer item={liveRadioBulletinItem} />,
        { service: 'igbo' },
      );

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

  it('should correctly render for 404 for persian', () => {
    const { container } = render(<ErrorPage errorCode={404} />, {
      service: 'persian',
    });
    expect(container).toMatchSnapshot();

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

    it('should render a Radio bulletin correctly', () => {
      const { container } = render(
        <BulletinContainer item={radioBulletinItem} />,
        { service: 'igbo' },
      );

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

  it('should correctly render for other status code', () => {
    const { container } = render(<ErrorPage errorCode={123} />, {
      service: 'news',
    });
    expect(container).toMatchSnapshot();

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

    it('should call fetch with the correct url when passed the full test path', async () => {
      await fetchPageData({ path: fullTestPath, pageType });

      expect(timeoutSpy).toHaveBeenCalledTimes(1);
      expect(fetch).toHaveBeenCalledWith(fullTestPath, fetchOptions);

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

    it('should render a TV bulletin correctly', () => {
      const { container } = render(
        <BulletinContainer item={tvBulletinItem} />,
        { service: 'igbo' },
      );

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

    it('should call fetch with the correct url when passed the full live path', async () => {
      await fetchPageData({ path: fullLivePath, pageType });

      expect(timeoutSpy).toHaveBeenCalledTimes(1);
      expect(fetch).toHaveBeenCalledWith(fullLivePath, fetchOptions);

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    act(() => {
      triggerIntersection({
        changes: [{ isIntersecting: true }],
        observer: observerInstanceA,
      });

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

  it('should correctly render for 500', () => {
    const { container } = render(<ErrorPage errorCode={500} />, {
      service: 'news',
    });
    expect(container).toMatchSnapshot();

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

  it('should correctly render for 500 for persian', async () => {
    const { container } = render(<ErrorPage errorCode={500} />, {
      service: 'persian',
    });
    expect(container).toMatchSnapshot();

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        expect(winston.transports.File).toHaveBeenCalledWith({
          filename: 'log/app.log',
          handleExceptions: true,
          humanReadableUnhandledException: true,
          format: 'Combine Mock',

• Read up
  Read up