Sign upLogin

bbc/simorgh

View on GitHub
Star
src/app/legacy/containers/IndexPageSection/utilities/storyRowsSplitter.test.jsx

Summary

Maintainability
F
1 wk
Test Coverage

File storyRowsSplitter.test.jsx has 515 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import range from 'ramda/src/range';
import getRows from './storyRowsSplitter';

const numberOfStories = {
  0: {
Severity: Major
Found in src/app/legacy/containers/IndexPageSection/utilities/storyRowsSplitter.test.jsx - About 1 day to fix

    Function rowsTest has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const rowsTest = value => {
  describe('first section', () => {
    it(`should correctly split ${value} stories`, () => {
      const items = numberOfStories[value].input;
      const isFirstSection = true;
    Severity: Minor
    Found in src/app/legacy/containers/IndexPageSection/utilities/storyRowsSplitter.test.jsx - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      const rowsTest = value => {
  describe('first section', () => {
    it(`should correctly split ${value} stories`, () => {
      const items = numberOfStories[value].input;
      const isFirstSection = true;
      Severity: Major
      Found in src/app/legacy/containers/IndexPageSection/utilities/storyRowsSplitter.test.jsx and 1 other location - About 2 days to fix
      src/app/legacy/containers/IndexPageSection/utilities/filterAllowedItems.test.jsx on lines 134..172

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 391.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        11: {
    input: range(0, 11),
    expectedFirstSection: {
      firstRow: [0],
      regularRows: [
      Severity: Major
      Found in src/app/legacy/containers/IndexPageSection/utilities/storyRowsSplitter.test.jsx and 1 other location - About 6 hrs to fix
      src/app/legacy/containers/IndexPageSection/utilities/storyRowsSplitter.test.jsx on lines 253..287

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 166.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        10: {
    input: range(0, 10),
    expectedFirstSection: {
      firstRow: [0],
      regularRows: [
      Severity: Major
      Found in src/app/legacy/containers/IndexPageSection/utilities/storyRowsSplitter.test.jsx and 1 other location - About 6 hrs to fix
      src/app/legacy/containers/IndexPageSection/utilities/storyRowsSplitter.test.jsx on lines 288..322

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 166.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        7: {
    input: range(0, 7),
    expectedFirstSection: {
      firstRow: [0],
      regularRows: [[1, 2, 3, 4]],
      Severity: Major
      Found in src/app/legacy/containers/IndexPageSection/utilities/storyRowsSplitter.test.jsx and 1 other location - About 5 hrs to fix
      src/app/legacy/containers/IndexPageSection/utilities/storyRowsSplitter.test.jsx on lines 143..165

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 142.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        6: {
    input: range(0, 6),
    expectedFirstSection: {
      firstRow: [0],
      regularRows: [[1, 2, 3, 4]],
      Severity: Major
      Found in src/app/legacy/containers/IndexPageSection/utilities/storyRowsSplitter.test.jsx and 1 other location - About 5 hrs to fix
      src/app/legacy/containers/IndexPageSection/utilities/storyRowsSplitter.test.jsx on lines 166..188

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 142.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        3: {
    input: range(0, 3),
    expectedFirstSection: {
      firstRow: [0],
      regularRows: [],
      Severity: Major
      Found in src/app/legacy/containers/IndexPageSection/utilities/storyRowsSplitter.test.jsx and 1 other location - About 4 hrs to fix
      src/app/legacy/containers/IndexPageSection/utilities/storyRowsSplitter.test.jsx on lines 51..73

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 118.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        2: {
    input: range(0, 2),
    expectedFirstSection: {
      firstRow: [0],
      regularRows: [],
      Severity: Major
      Found in src/app/legacy/containers/IndexPageSection/utilities/storyRowsSplitter.test.jsx and 1 other location - About 4 hrs to fix
      src/app/legacy/containers/IndexPageSection/utilities/storyRowsSplitter.test.jsx on lines 74..96

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 118.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status