Sign upLogin

bbc/simorgh

View on GitHub
Star
src/app/legacy/containers/StoryPromo/MediaIndicator/index.test.jsx

Summary

Maintainability
D
1 day
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it('should render video indicator correctly when inline', () => {
    const { container } = render(
      <MediaIndicator
        dir="ltr"
        item={videoItem}
Severity: Major
Found in src/app/legacy/containers/StoryPromo/MediaIndicator/index.test.jsx and 1 other location - About 2 hrs to fix
src/app/legacy/containers/StoryPromo/MediaIndicator/index.test.jsx on lines 154..165

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 77.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it('should render video indicator correctly when inline on RTL', () => {
    const { container } = render(
      <MediaIndicator
        dir="rtl"
        item={videoItem}
Severity: Major
Found in src/app/legacy/containers/StoryPromo/MediaIndicator/index.test.jsx and 1 other location - About 2 hrs to fix
src/app/legacy/containers/StoryPromo/MediaIndicator/index.test.jsx on lines 141..152

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 77.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  it('should render an audio item correctly', () => {
    const { container } = render(
      <MediaIndicator
        dir="ltr"
        item={audioItem}
Severity: Major
Found in src/app/legacy/containers/StoryPromo/MediaIndicator/index.test.jsx and 3 other locations - About 1 hr to fix
src/app/legacy/containers/StoryPromo/MediaIndicator/index.test.jsx on lines 129..139
src/app/legacy/containers/StoryPromo/MediaIndicator/index.test.jsx on lines 167..177
src/app/legacy/containers/StoryPromo/MediaIndicator/index.test.jsx on lines 179..189

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 74.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  it('should render a photo gallery item correctly', () => {
    const { container } = render(
      <MediaIndicator
        dir="ltr"
        item={photogalleryItem}
Severity: Major
Found in src/app/legacy/containers/StoryPromo/MediaIndicator/index.test.jsx and 3 other locations - About 1 hr to fix
src/app/legacy/containers/StoryPromo/MediaIndicator/index.test.jsx on lines 117..127
src/app/legacy/containers/StoryPromo/MediaIndicator/index.test.jsx on lines 129..139
src/app/legacy/containers/StoryPromo/MediaIndicator/index.test.jsx on lines 179..189

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 74.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  it('should render a video item correctly', () => {
    const { container } = render(
      <MediaIndicator
        dir="ltr"
        item={videoItem}
Severity: Major
Found in src/app/legacy/containers/StoryPromo/MediaIndicator/index.test.jsx and 3 other locations - About 1 hr to fix
src/app/legacy/containers/StoryPromo/MediaIndicator/index.test.jsx on lines 117..127
src/app/legacy/containers/StoryPromo/MediaIndicator/index.test.jsx on lines 167..177
src/app/legacy/containers/StoryPromo/MediaIndicator/index.test.jsx on lines 179..189

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 74.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  it('should render correctly even without duration', () => {
    const { container } = render(
      <MediaIndicator
        dir="ltr"
        item={noDurationItem}
Severity: Major
Found in src/app/legacy/containers/StoryPromo/MediaIndicator/index.test.jsx and 3 other locations - About 1 hr to fix
src/app/legacy/containers/StoryPromo/MediaIndicator/index.test.jsx on lines 117..127
src/app/legacy/containers/StoryPromo/MediaIndicator/index.test.jsx on lines 129..139
src/app/legacy/containers/StoryPromo/MediaIndicator/index.test.jsx on lines 167..177

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 74.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

const audioItem = {
  headlines: {
    headline: 'An audio item',
  },
  locators: {
Severity: Major
Found in src/app/legacy/containers/StoryPromo/MediaIndicator/index.test.jsx and 1 other location - About 1 hr to fix
src/app/legacy/containers/StoryPromo/MediaIndicator/index.test.jsx on lines 30..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

const videoItem = {
  headlines: {
    headline: 'A video item',
  },
  locators: {
Severity: Major
Found in src/app/legacy/containers/StoryPromo/MediaIndicator/index.test.jsx and 1 other location - About 1 hr to fix
src/app/legacy/containers/StoryPromo/MediaIndicator/index.test.jsx on lines 12..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status