Sign upLogin

bbc/unicode-bidirectional

View on GitHub
Star

Showing 46 of 46 total issues

Function matchingPDIForIndex has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

function matchingPDIForIndex(codepoints, index) {
  if (index >= codepoints.size) { return -1; }
  if (!includes([LRI, RLI, FSI], codepoints.get(index))) { return -1; }

  const after = codepoints.slice(index + 1);
Severity: Minor
Found in src/paragraph/matchingPDIForIndex.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function pdi has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function pdi(ch, bidiType, index, state) {
  if (ch !== PDI) return state;
  const isolateOverflow = state.get('overflowIsolateCount');
  const validIsolateCount = state.get('validIsolateCount');
Severity: Minor
Found in src/paragraph/rule/pdi.js - About 1 hr to fix

    Function bracketPairs has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function bracketPairs(points, bidiTypes) {
  // [1]: Sort the list of pairs of text positions in ascending order
  //      based on the text position of the opening paired bracket.
  // [*]: "If an opening paired bracket is found and there is no room in the stack,
  //       stop processing BD16 for the remainder of the isolating run sequence."
    Severity: Minor
    Found in src/neutral/bracketPairs.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      function isCurrentlyOverflowing(state) {
  const isolate = state.get('overflowIsolateCount');
  const embedding = state.get('overflowEmbeddingCount');
  return (isolate > 0 || embedding > 0); // [2]
}
      Severity: Major
      Found in src/paragraph/rule/lri.js and 1 other location - About 1 hr to fix
      src/paragraph/rule/rli.js on lines 6..10

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 61.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      function isCurrentlyOverflowing(state) {
  const isolate = state.get('overflowIsolateCount');
  const embedding = state.get('overflowEmbeddingCount');
  return (isolate > 0 || embedding > 0); // [2]
}
      Severity: Major
      Found in src/paragraph/rule/rli.js and 1 other location - About 1 hr to fix
      src/paragraph/rule/lri.js on lines 6..10

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 61.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function pdi has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      function pdi(ch, bidiType, index, state) {
  if (ch !== PDI) return state;
  const isolateOverflow = state.get('overflowIsolateCount');
  const validIsolateCount = state.get('validIsolateCount');
      Severity: Minor
      Found in src/paragraph/rule/pdi.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function rli has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function rli(ch, bidiType, index, state) {
  if (ch !== RLI) return state;
  const lastEntry = state.get('directionalStatusStack').peek();
  const lastLevel = lastEntry.get('level');
      Severity: Minor
      Found in src/paragraph/rule/rli.js - About 1 hr to fix

        Function lri has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function lri(ch, bidiType, index, state) {
  if (ch !== LRI) return state;
  const lastEntry = state.get('directionalStatusStack').peek();
  const lastLevel = lastEntry.get('level');
        Severity: Minor
        Found in src/paragraph/rule/lri.js - About 1 hr to fix

          Function lri has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

          function lri(ch, bidiType, index, state) {
  if (ch !== LRI) return state;
  const lastEntry = state.get('directionalStatusStack').peek();
  const lastLevel = lastEntry.get('level');
          Severity: Minor
          Found in src/paragraph/rule/lri.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function rli has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

          function rli(ch, bidiType, index, state) {
  if (ch !== RLI) return state;
  const lastEntry = state.get('directionalStatusStack').peek();
  const lastLevel = lastEntry.get('level');
          Severity: Minor
          Found in src/paragraph/rule/rli.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function finalState has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            const finalState = points.reduce((state, point, position) => {
    if (state.get('stackoverflow') === true) return state; // [*]

    const stack = state.get('stack');
          Severity: Minor
          Found in src/neutral/bracketPairs.js - About 1 hr to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                  return state
        .update('validIsolateCount', increase)
        .update('directionalStatusStack', (stack) => {
          return stack.push(new DirectionalStatusStackEntry({
            isolate: true,
            Severity: Minor
            Found in src/paragraph/rule/rli.js and 1 other location - About 55 mins to fix
            src/paragraph/rule/lri.js on lines 41..48

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 53.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                  return state
        .update('validIsolateCount', increase)
        .update('directionalStatusStack', (stack) => {
          return stack.push(new DirectionalStatusStackEntry({
            isolate: true,
            Severity: Minor
            Found in src/paragraph/rule/lri.js and 1 other location - About 55 mins to fix
            src/paragraph/rule/rli.js on lines 41..48

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 53.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function lro has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

            function lro(ch, bidiType, index, state) {
  if (ch !== LRO) return state;

  const lastLevel = state.get('directionalStatusStack').peek().get('level');
  const isolate = state.get('overflowIsolateCount');
            Severity: Minor
            Found in src/paragraph/rule/lro.js - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function fsi has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            function fsi(codepoint, bidiType, index, state, codepoints, bidiTypes) {
            Severity: Minor
            Found in src/paragraph/rule/fsi.js - About 45 mins to fix

              Function resolveBrackets has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              function resolveBrackets(bidiTypes, points, sos, eos, level, bidiTypesBeforeW1) {
              Severity: Minor
              Found in src/neutral/resolveBrackets.js - About 45 mins to fix

                Function rlo has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                function rlo(ch, bidiType, index, state) {
  if (ch !== RLO) return state;

  const lastLevel = state.get('directionalStatusStack').peek().get('level');
  const isolate = state.get('overflowIsolateCount');
                Severity: Minor
                Found in src/paragraph/rule/rlo.js - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function resolveIsolates has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                function resolveIsolates(types, codepoints, sos, eos, level) {
                Severity: Minor
                Found in src/neutral/resolveIsolates.js - About 35 mins to fix

                  Function enToL has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  function enToL(types, points, sos, eos, level) {
                  Severity: Minor
                  Found in src/weak/rule/enToL.js - About 35 mins to fix

                    Function en has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    function en(types, run, sos, eos, level) {
                    Severity: Minor
                    Found in src/weak/rule/en.js - About 35 mins to fix
                      Severity
                      Category
                      Status
                      Source
                      Language