bblimke/webmock

View on GitHub
lib/webmock/http_lib_adapters/httpclient_adapter.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method do_get has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    def do_get(req, proxy, conn, stream = false, &block)
      request_signature = build_request_signature(req, :reuse_existing)

      WebMock::RequestRegistry.instance.requested_signatures.put(request_signature)

Severity: Minor
Found in lib/webmock/http_lib_adapters/httpclient_adapter.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method do_get has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def do_get(req, proxy, conn, stream = false, &block)
      request_signature = build_request_signature(req, :reuse_existing)

      WebMock::RequestRegistry.instance.requested_signatures.put(request_signature)

Severity: Minor
Found in lib/webmock/http_lib_adapters/httpclient_adapter.rb - About 1 hr to fix

    Method build_webmock_response has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def build_webmock_response(httpclient_response, body = nil)
          webmock_response = WebMock::Response.new
          webmock_response.status = [httpclient_response.status, httpclient_response.reason]
    
          webmock_response.headers = {}.tap do |hash|
    Severity: Minor
    Found in lib/webmock/http_lib_adapters/httpclient_adapter.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method build_httpclient_response has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def build_httpclient_response(webmock_response, stream = false, req_header = nil, &block)
          body = stream ? StringIO.new(webmock_response.body) : webmock_response.body
          response = HTTP::Message.new_response(body, req_header)
          response.header.init_response(webmock_response.status[0])
          response.reason=webmock_response.status[1]
    Severity: Minor
    Found in lib/webmock/http_lib_adapters/httpclient_adapter.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method do_get has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def do_get(req, proxy, conn, stream = false, &block)
    Severity: Minor
    Found in lib/webmock/http_lib_adapters/httpclient_adapter.rb - About 35 mins to fix

      Method do_request_async has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def do_request_async(method, uri, query, body, extheader)
      Severity: Minor
      Found in lib/webmock/http_lib_adapters/httpclient_adapter.rb - About 35 mins to fix

        Method build_request_signature has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def build_request_signature(req, reuse_existing = false)
              uri = WebMock::Util::URI.heuristic_parse(req.header.request_uri.to_s)
              uri.query = WebMock::Util::QueryMapper.values_to_query(req.header.request_query, notation: WebMock::Config.instance.query_values_notation) if req.header.request_query
              uri.port = req.header.request_uri.port
        
        
        Severity: Minor
        Found in lib/webmock/http_lib_adapters/httpclient_adapter.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                def self.disable!
                  Object.send(:remove_const, :HTTPClient)
                  Object.send(:const_set, :HTTPClient, OriginalHttpClient)
                  if defined? ::JSONClient
                    Object.send(:remove_const, :JSONClient)
        Severity: Minor
        Found in lib/webmock/http_lib_adapters/httpclient_adapter.rb and 1 other location - About 15 mins to fix
        lib/webmock/http_lib_adapters/httpclient_adapter.rb on lines 24..29

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                def self.enable!
                  Object.send(:remove_const, :HTTPClient)
                  Object.send(:const_set, :HTTPClient, WebMockHTTPClient)
                  if defined? ::JSONClient
                    Object.send(:remove_const, :JSONClient)
        Severity: Minor
        Found in lib/webmock/http_lib_adapters/httpclient_adapter.rb and 1 other location - About 15 mins to fix
        lib/webmock/http_lib_adapters/httpclient_adapter.rb on lines 33..38

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status