Sign upLogin

bbottema/js-epub-maker

View on GitHub
Star

Showing 47 of 47 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        function addEpub2Nav(zip, epubConfig) {
            zip.folder('EPUB').file(epubConfig.slug + '.ncx', compile(templates.ncx, epubConfig));
        }
Severity: Minor
Found in src/js/template-builders/idpf-wasteland-builder.js and 2 other locations - About 35 mins to fix
src/js/template-builders/idpf-wasteland-builder.js on lines 51..53
src/js/template-builders/idpf-wasteland-builder.js on lines 78..80

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

    return code >= 0xaa && nonASCIIidentifierStart.test(String.fromCharCode(code));
Severity: Major
Found in demo/js/vendor/beautify-html.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return code >= 0xaa && nonASCIIidentifier.test(String.fromCharCode(code));
    Severity: Major
    Found in demo/js/vendor/beautify-html.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                          return token;
      Severity: Major
      Found in demo/js/vendor/beautify-html.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                            return [token, tag_name_type];
        Severity: Major
        Found in demo/js/vendor/beautify-html.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              if (code < 97) return code === 95;
          Severity: Major
          Found in demo/js/vendor/beautify-html.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                if (code < 123) return true;
            Severity: Major
            Found in demo/js/vendor/beautify-html.js - About 30 mins to fix
              Severity
              Category
              Status
              Source
              Language