Sign upLogin

bbyars/mountebank

View on GitHub
Star
src/controllers/impostersController.js

Summary

Maintainability
C
1 day
Test Coverage
A
98%

Function create has 134 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function create (protocols, imposters, logger, allowInjection) {
    function isFlagFalse (query, key) {
        return !helpers.defined(query[key]) || query[key].toLowerCase() !== 'false';
    }
Severity: Major
Found in src/controllers/impostersController.js - About 5 hrs to fix

    Function create has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

    function create (protocols, imposters, logger, allowInjection) {
    function isFlagFalse (query, key) {
        return !helpers.defined(query[key]) || query[key].toLowerCase() !== 'false';
    }
    Severity: Minor
    Found in src/controllers/impostersController.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function put has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        async function put (request, response) {
        const requestImposters = request.body.imposters || [],
            validationPromises = requestImposters.map(imposter => validate(imposter));

        logger.debug(requestDetails(request));
    Severity: Minor
    Found in src/controllers/impostersController.js - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                      validator = dryRunValidator.create({
                    testRequest: Protocol.testRequest,
                    testProxyResponse: Protocol.testProxyResponse,
                    additionalValidation: Protocol.validate,
                    allowInjection: allowInjection
      Severity: Minor
      Found in src/controllers/impostersController.js and 1 other location - About 35 mins to fix
      src/controllers/imposterController.js on lines 164..169

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Parsing error: Invalid ecmaVersion.
      Open

      'use strict';
      Severity: Minor
      Found in src/controllers/impostersController.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      There are no issues that match your filters.

      Category
      Status