Sign upLogin

bbyars/mountebank

View on GitHub
Star

Showing 386 of 386 total issues

Function create has 512 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function create (config, logger) {
    const imposterFns = {};
    let counter = 0,
        locks = 0;
Severity: Major
Found in src/models/filesystemBackedImpostersRepository.js - About 2 days to fix

    Function create has a Cognitive Complexity of 81 (exceeds 5 allowed). Consider refactoring.
    Open

    function create (config, logger) {
    const imposterFns = {};
    let counter = 0,
        locks = 0;
    Severity: Minor
    Found in src/models/filesystemBackedImpostersRepository.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function create has 277 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function create (stubs, proxy, callbackURL) {
    // injectState is deprecated in favor of imposterState, but kept for backwards compatibility
    const injectState = {}, // eslint-disable-line no-unused-vars
        pendingProxyResolutions = {},
        inProcessProxy = Boolean(proxy);
    Severity: Major
    Found in src/models/responseResolver.js - About 1 day to fix

      Function create has a Cognitive Complexity of 60 (exceeds 5 allowed). Consider refactoring.
      Open

      function create (stubs, proxy, callbackURL) {
    // injectState is deprecated in favor of imposterState, but kept for backwards compatibility
    const injectState = {}, // eslint-disable-line no-unused-vars
        pendingProxyResolutions = {},
        inProcessProxy = Boolean(proxy);
      Severity: Minor
      Found in src/models/responseResolver.js - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File filesystemBackedImpostersRepository.js has 542 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      'use strict';

const fsExtra = require('fs-extra'),
    prometheus = require('prom-client'),
    properLockFile = require('proper-lockfile'),
      Severity: Major
      Found in src/models/filesystemBackedImpostersRepository.js - About 1 day to fix

        Function stubRepository has 198 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function stubRepository (baseDir) {
        const imposterFile = `${baseDir}/imposter.json`;

        function metaPath (stubDir) {
            return `${baseDir}/${stubDir}/meta.json`;
        Severity: Major
        Found in src/models/filesystemBackedImpostersRepository.js - About 7 hrs to fix

          Function create has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
          Open

          function create (options) {
    function stubForResponse (originalStub, response, withPredicates) {
        // Each dry run only validates the first response, so we
        // explode the number of stubs to dry run each response separately
        const clonedStub = helpers.clone(originalStub),
          Severity: Minor
          Found in src/models/dryRunValidator.js - About 7 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function create has 191 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function create (protocols, imposters, logger, allowInjection) {
    function isFlagSet (query, key) {
        if (!helpers.defined(query[key])) {
            return false;
        }
          Severity: Major
          Found in src/controllers/imposterController.js - About 7 hrs to fix

            Function create has 176 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function create (options) {
    function stubForResponse (originalStub, response, withPredicates) {
        // Each dry run only validates the first response, so we
        // explode the number of stubs to dry run each response separately
        const clonedStub = helpers.clone(originalStub),
            Severity: Major
            Found in src/models/dryRunValidator.js - About 7 hrs to fix

              Function create has 172 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              async function create (Protocol, creationRequest, baseLogger, config, isAllowedConnection) {

    const metrics = getMetrics();

    function scopeFor (port) {
              Severity: Major
              Found in src/models/imposter.js - About 6 hrs to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                httpServer.create(config, mbConnection.logger(), mbConnection.getResponse).then(server => {
    mbConnection.setPort(server.port);
    mbConnection.setProxy(httpProxy.create(mbConnection.logger()));

    const metadata = server.metadata;
                Severity: Major
                Found in src/models/http/index.js and 1 other location - About 6 hrs to fix
                src/models/https/index.js on lines 8..18

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 170.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                httpsServer.create(config, mbConnection.logger(), mbConnection.getResponse).then(server => {
    mbConnection.setPort(server.port);
    mbConnection.setProxy(httpProxy.create(mbConnection.logger()));

    const metadata = server.metadata;
                Severity: Major
                Found in src/models/https/index.js and 1 other location - About 6 hrs to fix
                src/models/http/index.js on lines 8..18

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 170.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function create has 159 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function create (logger) {
    const BINARY_CONTENT_ENCODINGS = [
        'gzip', 'br', 'compress', 'deflate'
    ];
    const BINARY_MIME_TYPES = [
                Severity: Major
                Found in src/models/http/httpProxy.js - About 6 hrs to fix

                  Function exports has 154 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  module.exports = function (createBaseServer) {

    function create (options, logger, responseFn) {
        const connections = {},
            defaultResponse = options.defaultResponse || {};
                  Severity: Major
                  Found in src/models/http/baseHttpServer.js - About 6 hrs to fix

                    File behaviors.js has 420 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    'use strict';

/**
 * The functionality behind the behaviors field in the API, supporting post-processing responses
 * @module
                    Severity: Minor
                    Found in src/models/behaviors.js - About 6 hrs to fix

                      Function create has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
                      Open

                      function create (protocols, imposters, logger, allowInjection) {
    function isFlagSet (query, key) {
        if (!helpers.defined(query[key])) {
            return false;
        }
                      Severity: Minor
                      Found in src/controllers/imposterController.js - About 5 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function create has 134 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          function create (options, logger, responseFn) {
        const connections = {},
            defaultResponse = options.defaultResponse || {};

        function postProcess (stubResponse, request) {
                      Severity: Major
                      Found in src/models/http/baseHttpServer.js - About 5 hrs to fix

                        Function create has 134 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        function create (protocols, imposters, logger, allowInjection) {
    function isFlagFalse (query, key) {
        return !helpers.defined(query[key]) || query[key].toLowerCase() !== 'false';
    }
                        Severity: Major
                        Found in src/controllers/impostersController.js - About 5 hrs to fix

                          File cli.js has 389 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          'use strict';

const fs = require('fs-extra'),
    yargs = require('yargs'),
    aliases = {
                          Severity: Minor
                          Found in src/cli/cli.js - About 5 hrs to fix

                            Function load has 132 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                            function load (builtInProtocols, customProtocols, options, isAllowedConnection, mbLogger, impostersRepository) {
    function inProcessCreate (createProtocol) {
        return async (creationRequest, logger, responseFn) => {
            const server = await createProtocol(creationRequest, logger, responseFn),
                stubs = impostersRepository.stubsFor(server.port),
                            Severity: Major
                            Found in src/models/protocols.js - About 5 hrs to fix
                              Severity
                              Category
                              Status
                              Source
                              Language