Sign upLogin

bbyars/mountebank

View on GitHub
Star
src/models/filesystemBackedImpostersRepository.js

Summary

Maintainability
F
6 days
Test Coverage
A
94%

Function create has 512 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function create (config, logger) {
    const imposterFns = {};
    let counter = 0,
        locks = 0;
Severity: Major
Found in src/models/filesystemBackedImpostersRepository.js - About 2 days to fix

    Function create has a Cognitive Complexity of 81 (exceeds 5 allowed). Consider refactoring.
    Open

    function create (config, logger) {
    const imposterFns = {};
    let counter = 0,
        locks = 0;
    Severity: Minor
    Found in src/models/filesystemBackedImpostersRepository.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File filesystemBackedImpostersRepository.js has 542 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    'use strict';

const fsExtra = require('fs-extra'),
    prometheus = require('prom-client'),
    properLockFile = require('proper-lockfile'),
    Severity: Major
    Found in src/models/filesystemBackedImpostersRepository.js - About 1 day to fix

      Function stubRepository has 198 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function stubRepository (baseDir) {
        const imposterFile = `${baseDir}/imposter.json`;

        function metaPath (stubDir) {
            return `${baseDir}/${stubDir}/meta.json`;
      Severity: Major
      Found in src/models/filesystemBackedImpostersRepository.js - About 7 hrs to fix

        Function wrap has 63 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                function wrap (stub) {
            const cloned = helpers.clone(stub || {}),
                stubDir = stub ? stub.meta.dir : '';

            if (typeof stub === 'undefined') {
        Severity: Major
        Found in src/models/filesystemBackedImpostersRepository.js - About 2 hrs to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      allStubs.forEach(stub => {
                stub.responses = stub.responses.filter(response => !isRecordedResponse(response));
            });
          Severity: Minor
          Found in src/models/filesystemBackedImpostersRepository.js and 1 other location - About 45 mins to fix
          src/models/inMemoryImpostersRepository.js on lines 226..228

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  Object.keys(imposterFns[id]).forEach(key => {
            imposter[key] = imposterFns[id][key];
        });
          Severity: Minor
          Found in src/models/filesystemBackedImpostersRepository.js and 2 other locations - About 40 mins to fix
          src/models/compatibility.js on lines 124..126
          src/models/imposterPrinter.js on lines 26..28

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  lockAcquireDuration: new prometheus.Histogram({
            name: 'mb_lock_acquire_duration_seconds',
            help: 'Time it takes to acquire a file lock',
            buckets: [0.1, 0.2, 0.5, 1, 3, 5, 10, 30],
            labelNames: ['caller']
          Severity: Minor
          Found in src/models/filesystemBackedImpostersRepository.js and 1 other location - About 30 mins to fix
          src/models/responseResolver.js on lines 18..23

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Parsing error: Invalid ecmaVersion.
          Open

          'use strict';
          Severity: Minor
          Found in src/models/filesystemBackedImpostersRepository.js by eslint

          For more information visit Source: http://eslint.org/docs/rules/

          There are no issues that match your filters.

          Category
          Status