bbyars/mountebank

View on GitHub
src/models/imposter.js

Summary

Maintainability
C
1 day
Test Coverage
B
81%

Function create has 172 lines of code (exceeds 25 allowed). Consider refactoring.
Open

async function create (Protocol, creationRequest, baseLogger, config, isAllowedConnection) {

    const metrics = getMetrics();

    function scopeFor (port) {
Severity: Major
Found in src/models/imposter.js - About 6 hrs to fix

    Function create has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

    async function create (Protocol, creationRequest, baseLogger, config, isAllowedConnection) {
    
        const metrics = getMetrics();
    
        function scopeFor (port) {
    Severity: Minor
    Found in src/models/imposter.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function createImposterMetrics has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function createImposterMetrics () {
            const impostersMetrics = {
                predicateMatchDuration: new prometheus.Histogram({
                    name: 'mb_predicate_match_duration_seconds',
                    help: 'Time it takes to match the predicates and select a stub',
    Severity: Minor
    Found in src/models/imposter.js - About 1 hr to fix

      Function create has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      async function create (Protocol, creationRequest, baseLogger, config, isAllowedConnection) {
      Severity: Minor
      Found in src/models/imposter.js - About 35 mins to fix

        Function recordMatch has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            async function recordMatch (stub, request, response, responseConfig, start) {
        Severity: Minor
        Found in src/models/imposter.js - About 35 mins to fix

          Parsing error: Invalid ecmaVersion.
          Open

          'use strict';
          Severity: Minor
          Found in src/models/imposter.js by eslint

          For more information visit Source: http://eslint.org/docs/rules/

          There are no issues that match your filters.

          Category
          Status