Sign upLogin

bbyars/mountebank

View on GitHub
Star
src/models/responseResolver.js

Summary

Maintainability
F
3 days
Test Coverage
A
99%

Function create has 277 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function create (stubs, proxy, callbackURL) {
    // injectState is deprecated in favor of imposterState, but kept for backwards compatibility
    const injectState = {}, // eslint-disable-line no-unused-vars
        pendingProxyResolutions = {},
        inProcessProxy = Boolean(proxy);
Severity: Major
Found in src/models/responseResolver.js - About 1 day to fix

    Function create has a Cognitive Complexity of 60 (exceeds 5 allowed). Consider refactoring.
    Open

    function create (stubs, proxy, callbackURL) {
    // injectState is deprecated in favor of imposterState, but kept for backwards compatibility
    const injectState = {}, // eslint-disable-line no-unused-vars
        pendingProxyResolutions = {},
        inProcessProxy = Boolean(proxy);
    Severity: Minor
    Found in src/models/responseResolver.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File responseResolver.js has 302 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    'use strict';

const prometheus = require('prom-client'),
    stringify = require('safe-stable-stringify'),
    helpers = require('../util/helpers.js'),
    Severity: Minor
    Found in src/models/responseResolver.js - About 3 hrs to fix

      Function predicatesFor has 55 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function predicatesFor (request, matchers, logger) {
        const predicates = [];

        matchers.forEach(matcher => {
            if (matcher.inject) {
      Severity: Major
      Found in src/models/responseResolver.js - About 2 hrs to fix

        Function proxyAndRecord has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            async function proxyAndRecord (responseConfig, request, logger, requestDetails, imposterState) {
        const startTime = new Date(),
            observeProxyDuration = metrics.proxyDuration.startTimer();

        metrics.proxyCount.inc({ imposter: logger.scopePrefix });
        Severity: Minor
        Found in src/models/responseResolver.js - About 1 hr to fix

          Function inject has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function inject (request, fn, logger, imposterState) {
        if (request.isDryRun) {
            return Promise.resolve({});
        }
          Severity: Minor
          Found in src/models/responseResolver.js - About 1 hr to fix

            Function resolve has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                async function resolve (responseConfig, request, logger, imposterState, options) {
            Severity: Minor
            Found in src/models/responseResolver.js - About 35 mins to fix

              Function proxyAndRecord has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  async function proxyAndRecord (responseConfig, request, logger, requestDetails, imposterState) {
              Severity: Minor
              Found in src/models/responseResolver.js - About 35 mins to fix

                Function processResponse has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    function processResponse (responseConfig, request, logger, imposterState, requestDetails) {
                Severity: Minor
                Found in src/models/responseResolver.js - About 35 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return Promise.reject(exceptions.ValidationError('unrecognized response type',
                { source: helpers.clone(responseConfig) }));
                  Severity: Major
                  Found in src/models/responseResolver.js - About 30 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        proxyDuration: new prometheus.Histogram({
        name: 'mb_proxy_duration_seconds',
        help: 'Time it takes to get the response from the downstream service',
        buckets: [0.1, 0.2, 0.5, 1, 3, 5, 10, 30],
        labelNames: ['imposter']
                    Severity: Minor
                    Found in src/models/responseResolver.js and 1 other location - About 30 mins to fix
                    src/models/filesystemBackedImpostersRepository.js on lines 95..100

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Parsing error: Invalid ecmaVersion.
                    Open

                    'use strict';
                    Severity: Minor
                    Found in src/models/responseResolver.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    There are no issues that match your filters.

                    Category
                    Status