Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/base.rb

Summary

Maintainability
C
1 day
Test Coverage
A
95%

Class Base has 34 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Base
    class << self
      # 接頭辞（反応するコマンド）の配列を返す
      # @return [Array<String>]
      attr_reader :prefixes
Severity: Minor
Found in lib/bcdice/base.rb - About 4 hrs to fix

    Method debug has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def debug(target, *values)
      return unless @debug

      targetStr = target.is_a?(String) ? target : target.inspect
    Severity: Minor
    Found in lib/bcdice/base.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method check_result has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def check_result(total, rand_results, cmp_op, target)
      ret = check_result_legacy(total, rand_results, cmp_op, target)
      return ret if ret

      sides_list = rand_results.map(&:sides)
    Severity: Minor
    Found in lib/bcdice/base.rb - About 1 hr to fix

      Method dice_command has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def dice_command(command)
      command = command.upcase if @enabled_upcase_input

      m = self.class.prefixes_pattern.match(command)
      unless m
      Severity: Minor
      Found in lib/bcdice/base.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method result_2d6 has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def result_2d6(total, dice_total, value_list, cmp_op, target); end
      Severity: Minor
      Found in lib/bcdice/base.rb - About 35 mins to fix

        Method result_nd6 has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def result_nd6(total, dice_total, value_list, cmp_op, target); end
        Severity: Minor
        Found in lib/bcdice/base.rb - About 35 mins to fix

          Method result_nd10 has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def result_nd10(total, dice_total, value_list, cmp_op, target); end
          Severity: Minor
          Found in lib/bcdice/base.rb - About 35 mins to fix

            Method check_result has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                def check_result(total, rand_results, cmp_op, target)
      ret = check_result_legacy(total, rand_results, cmp_op, target)
      return ret if ret

      sides_list = rand_results.map(&:sides)
            Severity: Minor
            Found in lib/bcdice/base.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                  return result_ndx(total, cmp_op, target)
            Severity: Major
            Found in lib/bcdice/base.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                    return ret if ret
              Severity: Major
              Found in lib/bcdice/base.rb - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      ret =
        case sides_list
        when [100]
          result_1d100(total, dice_total, cmp_op, target)
        when [20]
                Severity: Minor
                Found in lib/bcdice/base.rb and 1 other location - About 30 mins to fix
                lib/bcdice/deprecated/checker.rb on lines 20..27

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 32.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status