Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/AFF2e.rb

Summary

Maintainability
A
3 hrs
Test Coverage
A
98%

Method eval_game_system_specific_command has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def eval_game_system_specific_command(command)
        case command
        when /\AFF/
          # 対抗なしロール
          # '成功' or '失敗' を出力する
Severity: Minor
Found in lib/bcdice/game_system/AFF2e.rb - About 1 hr to fix

    Method successful_or_failed has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

          def successful_or_failed(total, diff)
        case total
        when  2
          diff <=  1 ? '成功（大成功ではない）' : '大成功！'
        when 12
    Severity: Minor
    Found in lib/bcdice/game_system/AFF2e.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method eval_game_system_specific_command has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def eval_game_system_specific_command(command)
        case command
        when /\AFF/
          # 対抗なしロール
          # '成功' or '失敗' を出力する
    Severity: Minor
    Found in lib/bcdice/game_system/AFF2e.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status