Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/Amadeus.rb

Summary

Maintainability
B
6 hrs
Test Coverage
A
100%

Method roll_amadeus has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

      def roll_amadeus(command)
        m = /^R([A-DS])([+\-\d]*)(@(\d))?((>=?)([+\-\d]*))?(@(\d))?$/i.match(command)
        unless m
          return nil
        end
Severity: Minor
Found in lib/bcdice/game_system/Amadeus.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method roll_amadeus has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def roll_amadeus(command)
        m = /^R([A-DS])([+\-\d]*)(@(\d))?((>=?)([+\-\d]*))?(@(\d))?$/i.match(command)
        unless m
          return nil
        end
Severity: Major
Found in lib/bcdice/game_system/Amadeus.rb - About 2 hrs to fix

    Method translate_tables has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def translate_tables(locale)
          {
            "ECT" => DiceTable::Table.from_i18n("Amadeus.table.ECT", locale),
            "BST" => DiceTable::Table.from_i18n("Amadeus.table.BST", locale),
            "RT" => DiceTable::Table.from_i18n("Amadeus.table.RT", locale),
    Severity: Minor
    Found in lib/bcdice/game_system/Amadeus.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status