Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/AniMalus.rb

Summary

Maintainability
C
1 day
Test Coverage

Method resolute_attacking has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

      def resolute_attacking(command)
        m = /^([-+]\d+)?AA<=(\d+)$/.match(command)
        return nil unless m

        num_bonus = m[1].to_i
Severity: Minor
Found in lib/bcdice/game_system/AniMalus.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method resolute_attacking has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def resolute_attacking(command)
        m = /^([-+]\d+)?AA<=(\d+)$/.match(command)
        return nil unless m

        num_bonus = m[1].to_i
Severity: Minor
Found in lib/bcdice/game_system/AniMalus.rb - About 1 hr to fix

    Method resolute_action has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def resolute_action(command)
        m = /^(\d+)([-+]\d+)?AM<=(\d+),(\d)$/.match(command)
        return nil unless m

        num_dice = m[1].to_i
    Severity: Minor
    Found in lib/bcdice/game_system/AniMalus.rb - About 1 hr to fix

      Method resolute_investigation has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def resolute_investigation(command)
        m = /^([-+]\d+)?AI<=(\d+),(\d)$/.match(command)
        return nil unless m

        num_bonus = m[1].to_i
      Severity: Minor
      Found in lib/bcdice/game_system/AniMalus.rb - About 1 hr to fix

        Method resolute_action has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

              def resolute_action(command)
        m = /^(\d+)([-+]\d+)?AM<=(\d+),(\d)$/.match(command)
        return nil unless m

        num_dice = m[1].to_i
        Severity: Minor
        Found in lib/bcdice/game_system/AniMalus.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method resolute_guarding has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

              def resolute_guarding(command)
        m = /^([-+]\d+)?AG=(\d+)$/.match(command)
        return nil unless m

        num_bonus = m[1].to_i
        Severity: Minor
        Found in lib/bcdice/game_system/AniMalus.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method resolute_investigation has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

              def resolute_investigation(command)
        m = /^([-+]\d+)?AI<=(\d+),(\d)$/.match(command)
        return nil unless m

        num_bonus = m[1].to_i
        Severity: Minor
        Found in lib/bcdice/game_system/AniMalus.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method resolute_guarding has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def resolute_guarding(command)
        m = /^([-+]\d+)?AG=(\d+)$/.match(command)
        return nil unless m

        num_bonus = m[1].to_i
        Severity: Minor
        Found in lib/bcdice/game_system/AniMalus.rb - About 1 hr to fix

          There are no issues that match your filters.

          Category
          Status