bcdice/BCDice

View on GitHub
lib/bcdice/game_system/Ayabito.rb

Summary

Maintainability
D
2 days
Test Coverage

File Ayabito.rb has 374 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'bcdice/command/parser'

module BCDice
  module GameSystem
    class Ayabito < Base
Severity: Minor
Found in lib/bcdice/game_system/Ayabito.rb - About 5 hrs to fix

    Method check_action has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

          def check_action(command)
            parser = Command::Parser.new("AB", round_type: RoundType::CEIL).has_prefix_number.enable_critical.enable_dollar.restrict_cmp_op_to(nil, :>=)
            parsed = parser.parse(command)
            return nil if parsed.nil?
    
    
    Severity: Minor
    Found in lib/bcdice/game_system/Ayabito.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method check_action has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def check_action(command)
            parser = Command::Parser.new("AB", round_type: RoundType::CEIL).has_prefix_number.enable_critical.enable_dollar.restrict_cmp_op_to(nil, :>=)
            parsed = parser.parse(command)
            return nil if parsed.nil?
    
    
    Severity: Minor
    Found in lib/bcdice/game_system/Ayabito.rb - About 1 hr to fix

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

              'ET' => DiceTable::D66Table.new(
                '感情表',
                D66SortType::NO_SORT,
                {
                  11 => '信頼/不信感',
      Severity: Major
      Found in lib/bcdice/game_system/Ayabito.rb and 4 other locations - About 2 hrs to fix
      lib/bcdice/game_system/BloodMoon.rb on lines 207..246
      lib/bcdice/game_system/DarkDaysDrive.rb on lines 197..236
      lib/bcdice/game_system/DivineCharger.rb on lines 121..160
      lib/bcdice/game_system/Yggdrasill.rb on lines 555..599

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 79.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

              'CET' => DiceTable::D66LeftRangeTable.new(
                '交流表',
                D66SortType::NO_SORT,
                [
                  [1..1, Array.new(6, "感情~性格までの任意のテーマを選択する。")],
      Severity: Major
      Found in lib/bcdice/game_system/Ayabito.rb and 8 other locations - About 40 mins to fix
      lib/bcdice/game_system/Ayabito.rb on lines 136..158
      lib/bcdice/game_system/Ayabito.rb on lines 160..182
      lib/bcdice/game_system/Ayabito.rb on lines 246..268
      lib/bcdice/game_system/Ayabito.rb on lines 270..292
      lib/bcdice/game_system/Ayabito.rb on lines 294..316
      lib/bcdice/game_system/Ayabito.rb on lines 318..340
      lib/bcdice/game_system/Ayabito.rb on lines 342..364
      lib/bcdice/game_system/Ayabito.rb on lines 366..388

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 37.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

              'KST' => DiceTable::D66LeftRangeTable.new(
                '霞ヶ関シーン表',
                D66SortType::NO_SORT,
                [
                  [1..1, Array.new(6, "子~巳までの任意の十二支を選択する。")],
      Severity: Major
      Found in lib/bcdice/game_system/Ayabito.rb and 8 other locations - About 40 mins to fix
      lib/bcdice/game_system/Ayabito.rb on lines 136..158
      lib/bcdice/game_system/Ayabito.rb on lines 160..182
      lib/bcdice/game_system/Ayabito.rb on lines 184..206
      lib/bcdice/game_system/Ayabito.rb on lines 246..268
      lib/bcdice/game_system/Ayabito.rb on lines 270..292
      lib/bcdice/game_system/Ayabito.rb on lines 294..316
      lib/bcdice/game_system/Ayabito.rb on lines 318..340
      lib/bcdice/game_system/Ayabito.rb on lines 366..388

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 37.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

              'BST' => DiceTable::D66LeftRangeTable.new(
                '場面演出シーン表',
                D66SortType::NO_SORT,
                [
                  [1..1, Array.new(6, "子~巳までの任意の十二支を選択する。")],
      Severity: Major
      Found in lib/bcdice/game_system/Ayabito.rb and 8 other locations - About 40 mins to fix
      lib/bcdice/game_system/Ayabito.rb on lines 136..158
      lib/bcdice/game_system/Ayabito.rb on lines 184..206
      lib/bcdice/game_system/Ayabito.rb on lines 246..268
      lib/bcdice/game_system/Ayabito.rb on lines 270..292
      lib/bcdice/game_system/Ayabito.rb on lines 294..316
      lib/bcdice/game_system/Ayabito.rb on lines 318..340
      lib/bcdice/game_system/Ayabito.rb on lines 342..364
      lib/bcdice/game_system/Ayabito.rb on lines 366..388

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 37.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

              'NST' => DiceTable::D66LeftRangeTable.new(
                '日本橋シーン表',
                D66SortType::NO_SORT,
                [
                  [1..1, Array.new(6, "子~巳までの任意の十二支を選択する。")],
      Severity: Major
      Found in lib/bcdice/game_system/Ayabito.rb and 8 other locations - About 40 mins to fix
      lib/bcdice/game_system/Ayabito.rb on lines 136..158
      lib/bcdice/game_system/Ayabito.rb on lines 160..182
      lib/bcdice/game_system/Ayabito.rb on lines 184..206
      lib/bcdice/game_system/Ayabito.rb on lines 246..268
      lib/bcdice/game_system/Ayabito.rb on lines 270..292
      lib/bcdice/game_system/Ayabito.rb on lines 318..340
      lib/bcdice/game_system/Ayabito.rb on lines 342..364
      lib/bcdice/game_system/Ayabito.rb on lines 366..388

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 37.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

              'SST' => DiceTable::D66LeftRangeTable.new(
                '新宿シーン表',
                D66SortType::NO_SORT,
                [
                  [1..1, Array.new(6, "子~巳までの任意の十二支を選択する。")],
      Severity: Major
      Found in lib/bcdice/game_system/Ayabito.rb and 8 other locations - About 40 mins to fix
      lib/bcdice/game_system/Ayabito.rb on lines 136..158
      lib/bcdice/game_system/Ayabito.rb on lines 160..182
      lib/bcdice/game_system/Ayabito.rb on lines 184..206
      lib/bcdice/game_system/Ayabito.rb on lines 246..268
      lib/bcdice/game_system/Ayabito.rb on lines 270..292
      lib/bcdice/game_system/Ayabito.rb on lines 294..316
      lib/bcdice/game_system/Ayabito.rb on lines 318..340
      lib/bcdice/game_system/Ayabito.rb on lines 342..364

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 37.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

              'AST' => DiceTable::D66LeftRangeTable.new(
                '浅草シーン表',
                D66SortType::NO_SORT,
                [
                  [1..1, Array.new(6, "子~巳までの任意の十二支を選択する。")],
      Severity: Major
      Found in lib/bcdice/game_system/Ayabito.rb and 8 other locations - About 40 mins to fix
      lib/bcdice/game_system/Ayabito.rb on lines 136..158
      lib/bcdice/game_system/Ayabito.rb on lines 160..182
      lib/bcdice/game_system/Ayabito.rb on lines 184..206
      lib/bcdice/game_system/Ayabito.rb on lines 270..292
      lib/bcdice/game_system/Ayabito.rb on lines 294..316
      lib/bcdice/game_system/Ayabito.rb on lines 318..340
      lib/bcdice/game_system/Ayabito.rb on lines 342..364
      lib/bcdice/game_system/Ayabito.rb on lines 366..388

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 37.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

              'TST' => DiceTable::D66LeftRangeTable.new(
                '帝都東京シーン表',
                D66SortType::NO_SORT,
                [
                  [1..1, Array.new(6, "子~巳までの任意の十二支を選択する。")],
      Severity: Major
      Found in lib/bcdice/game_system/Ayabito.rb and 8 other locations - About 40 mins to fix
      lib/bcdice/game_system/Ayabito.rb on lines 160..182
      lib/bcdice/game_system/Ayabito.rb on lines 184..206
      lib/bcdice/game_system/Ayabito.rb on lines 246..268
      lib/bcdice/game_system/Ayabito.rb on lines 270..292
      lib/bcdice/game_system/Ayabito.rb on lines 294..316
      lib/bcdice/game_system/Ayabito.rb on lines 318..340
      lib/bcdice/game_system/Ayabito.rb on lines 342..364
      lib/bcdice/game_system/Ayabito.rb on lines 366..388

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 37.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

              'UST' => DiceTable::D66LeftRangeTable.new(
                '上野シーン表',
                D66SortType::NO_SORT,
                [
                  [1..1, Array.new(6, "子~巳までの任意の十二支を選択する。")],
      Severity: Major
      Found in lib/bcdice/game_system/Ayabito.rb and 8 other locations - About 40 mins to fix
      lib/bcdice/game_system/Ayabito.rb on lines 136..158
      lib/bcdice/game_system/Ayabito.rb on lines 160..182
      lib/bcdice/game_system/Ayabito.rb on lines 184..206
      lib/bcdice/game_system/Ayabito.rb on lines 246..268
      lib/bcdice/game_system/Ayabito.rb on lines 294..316
      lib/bcdice/game_system/Ayabito.rb on lines 318..340
      lib/bcdice/game_system/Ayabito.rb on lines 342..364
      lib/bcdice/game_system/Ayabito.rb on lines 366..388

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 37.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

              'GST' => DiceTable::D66LeftRangeTable.new(
                '銀座シーン表',
                D66SortType::NO_SORT,
                [
                  [1..1, Array.new(6, "子~巳までの任意の十二支を選択する。")],
      Severity: Major
      Found in lib/bcdice/game_system/Ayabito.rb and 8 other locations - About 40 mins to fix
      lib/bcdice/game_system/Ayabito.rb on lines 136..158
      lib/bcdice/game_system/Ayabito.rb on lines 160..182
      lib/bcdice/game_system/Ayabito.rb on lines 184..206
      lib/bcdice/game_system/Ayabito.rb on lines 246..268
      lib/bcdice/game_system/Ayabito.rb on lines 270..292
      lib/bcdice/game_system/Ayabito.rb on lines 294..316
      lib/bcdice/game_system/Ayabito.rb on lines 342..364
      lib/bcdice/game_system/Ayabito.rb on lines 366..388

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 37.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status