Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/BattleTech.rb

Summary

Maintainability
D
2 days
Test Coverage
A
99%

File BattleTech.rb has 481 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'bcdice/format'
require 'bcdice/command/parser'
require 'bcdice/dice_table/table'
require 'bcdice/dice_table/range_table'
Severity: Minor
Found in lib/bcdice/game_system/BattleTech.rb - About 7 hrs to fix

    Method eval_game_system_specific_command has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def eval_game_system_specific_command(command)
        result = roll_tables(command, TABLES)
        return result if result

        if (ppc_parse_result = ppc_parser.parse(command))
    Severity: Minor
    Found in lib/bcdice/game_system/BattleTech.rb - About 1 hr to fix

      Method consciousness_roll has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def consciousness_roll(damage)
        unless (1..6).include?(damage)
          return nil
        end
      Severity: Minor
      Found in lib/bcdice/game_system/BattleTech.rb - About 1 hr to fix

        Method getHitResult has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def getHitResult(count, damageFunc, tail)
        m = /\A([LCR][LU]?)?(\+\d+)?>=(\d+)/.match(tail)
        return nil unless m

        side = m[1] || 'C'
        Severity: Minor
        Found in lib/bcdice/game_system/BattleTech.rb - About 1 hr to fix

          Method getTotalDamage has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def getTotalDamage(damages)
        parts = ['頭',
                 '胴中央',
                 '右胴',
                 '左胴',
          Severity: Minor
          Found in lib/bcdice/game_system/BattleTech.rb - About 1 hr to fix

            Method eval_game_system_specific_command has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                  def eval_game_system_specific_command(command)
        result = roll_tables(command, TABLES)
        return result if result

        if (ppc_parse_result = ppc_parser.parse(command))
            Severity: Minor
            Found in lib/bcdice/game_system/BattleTech.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method getHitResult has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                  def getHitResult(count, damageFunc, tail)
        m = /\A([LCR][LU]?)?(\+\d+)?>=(\d+)/.match(tail)
        return nil unless m

        side = m[1] || 'C'
            Severity: Minor
            Found in lib/bcdice/game_system/BattleTech.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method getDamages has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                  def getDamages(damageFunc, partTable, damages)
        resultText = ''
        damage, dice, isLrm = damageFunc.call()

        damagePartCount = 1
            Severity: Minor
            Found in lib/bcdice/game_system/BattleTech.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method getTotalDamage has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                  def getTotalDamage(damages)
        parts = ['頭',
                 '胴中央',
                 '右胴',
                 '左胴',
            Severity: Minor
            Found in lib/bcdice/game_system/BattleTech.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method consciousness_roll has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                  def consciousness_roll(damage)
        unless (1..6).include?(damage)
          return nil
        end
            Severity: Minor
            Found in lib/bcdice/game_system/BattleTech.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                    return nil
            Severity: Major
            Found in lib/bcdice/game_system/BattleTech.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return nil
              Severity: Major
              Found in lib/bcdice/game_system/BattleTech.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                          return getHitResult(count, damageFunc, tail)
                Severity: Major
                Found in lib/bcdice/game_system/BattleTech.rb - About 30 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                            'R' => DiceTable::RangeTable.new(
            '命中部位表（右）',
            '2D6',
            [
              [2,    new(RIGHT_TORSO, true)],
                  Severity: Major
                  Found in lib/bcdice/game_system/BattleTech.rb and 1 other location - About 1 hr to fix
                  lib/bcdice/game_system/BattleTech.rb on lines 426..440

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 56.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                            'L' => DiceTable::RangeTable.new(
            '命中部位表（左）',
            '2D6',
            [
              [2,    new(LEFT_TORSO, true)],
                  Severity: Major
                  Found in lib/bcdice/game_system/BattleTech.rb and 1 other location - About 1 hr to fix
                  lib/bcdice/game_system/BattleTech.rb on lines 457..471

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 56.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                            'LU' => DiceTable::RangeTable.new(
            '命中部位表（左上半身）',
            '1D6',
            [
              [1..2, new(LEFT_TORSO, false)],
                  Severity: Minor
                  Found in lib/bcdice/game_system/BattleTech.rb and 1 other location - About 15 mins to fix
                  lib/bcdice/game_system/BattleTech.rb on lines 497..505

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 26.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                            'RU' => DiceTable::RangeTable.new(
            '命中部位表（右上半身）',
            '1D6',
            [
              [1..2, new(RIGHT_TORSO, false)],
                  Severity: Minor
                  Found in lib/bcdice/game_system/BattleTech.rb and 1 other location - About 15 mins to fix
                  lib/bcdice/game_system/BattleTech.rb on lines 474..482

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 26.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status