Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/BladeOfArcana.rb

Summary

Maintainability
D
1 day
Test Coverage
A
97%

Method eval_game_system_specific_command has 131 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def eval_game_system_specific_command(command)
        case command.upcase
        when /^(\d+)A(\d*)([CF]?)(\d*)([CF]?)(\d*)$/
          counts = Regexp.last_match(1).to_i
          judgment = Regexp.last_match(2).to_i
Severity: Major
Found in lib/bcdice/game_system/BladeOfArcana.rb - About 5 hrs to fix

    Method rollAct has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

          def rollAct(counts, judgment = 0, critical = 0, fumble = 0)
        if critical < 1
          critical = 1
        end
        if judgment <= 0
    Severity: Minor
    Found in lib/bcdice/game_system/BladeOfArcana.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method rollAct has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def rollAct(counts, judgment = 0, critical = 0, fumble = 0)
        if critical < 1
          critical = 1
        end
        if judgment <= 0
    Severity: Minor
    Found in lib/bcdice/game_system/BladeOfArcana.rb - About 1 hr to fix

      Method eval_game_system_specific_command has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def eval_game_system_specific_command(command)
        case command.upcase
        when /^(\d+)A(\d*)([CF]?)(\d*)([CF]?)(\d*)$/
          counts = Regexp.last_match(1).to_i
          judgment = Regexp.last_match(2).to_i
      Severity: Minor
      Found in lib/bcdice/game_system/BladeOfArcana.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                return tableText(title, table, sign)
      Severity: Major
      Found in lib/bcdice/game_system/BladeOfArcana.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return nil
        Severity: Major
        Found in lib/bcdice/game_system/BladeOfArcana.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                    return tableText(title, table, sign)
          Severity: Major
          Found in lib/bcdice/game_system/BladeOfArcana.rb - About 30 mins to fix

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                    when /^CTR([+-]?)$/
          sign = Regexp.last_match(1)
          title = '因縁表(リインカーネイション)　『BAR』P51、299'
          table = [
            "【他生】",
            Severity: Major
            Found in lib/bcdice/game_system/BladeOfArcana.rb and 3 other locations - About 40 mins to fix
            lib/bcdice/game_system/BladeOfArcana.rb on lines 69..96
            lib/bcdice/game_system/BladeOfArcana.rb on lines 127..154
            lib/bcdice/game_system/BladeOfArcana.rb on lines 156..183

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 38.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                    when /^CT3([+-]?)$/
          sign = Regexp.last_match(1)
          title = '因縁表(The 3rd)　『BoA3』P292'
          table = [
            "【他生】",
            Severity: Major
            Found in lib/bcdice/game_system/BladeOfArcana.rb and 3 other locations - About 40 mins to fix
            lib/bcdice/game_system/BladeOfArcana.rb on lines 98..125
            lib/bcdice/game_system/BladeOfArcana.rb on lines 127..154
            lib/bcdice/game_system/BladeOfArcana.rb on lines 156..183

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 38.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                    when /^DJV(-?)$/
          sign = Regexp.last_match(1)
          title = '前世邂逅表（デジャブ）　『BAR』P235'
          table = [
            "【鮮烈な風】\n風は懐かしい匂いを、香りを運んでくる。それは……。",
            Severity: Major
            Found in lib/bcdice/game_system/BladeOfArcana.rb and 3 other locations - About 40 mins to fix
            lib/bcdice/game_system/BladeOfArcana.rb on lines 69..96
            lib/bcdice/game_system/BladeOfArcana.rb on lines 98..125
            lib/bcdice/game_system/BladeOfArcana.rb on lines 156..183

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 38.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                    when /^AKST([+-]?)$/
          sign = Regexp.last_match(1)
          title = '悪徳シーン表　『GoV』P16、164'
          table = [
            "▼ウェントス／止まない風\n【行動】殺戮者の狂気に当てられたのか、通り魔的殺人者が現れる。切り裂かれた人々の悲鳴が響き渡る。",
            Severity: Major
            Found in lib/bcdice/game_system/BladeOfArcana.rb and 3 other locations - About 40 mins to fix
            lib/bcdice/game_system/BladeOfArcana.rb on lines 69..96
            lib/bcdice/game_system/BladeOfArcana.rb on lines 98..125
            lib/bcdice/game_system/BladeOfArcana.rb on lines 127..154

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 38.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status