Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/ChaosFlare.rb

Summary

Maintainability
B
5 hrs
Test Coverage
A
92%

Method cf_roll has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

      def cf_roll(command)
        parser = Command::Parser.new(/\d*CF/, round_type: round_type)
                                .enable_critical
                                .enable_fumble
Severity: Minor
Found in lib/bcdice/game_system/ChaosFlare.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method cf_roll has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def cf_roll(command)
        parser = Command::Parser.new(/\d*CF/, round_type: round_type)
                                .enable_critical
                                .enable_fumble
Severity: Minor
Found in lib/bcdice/game_system/ChaosFlare.rb - About 1 hr to fix

    Method result_2d6 has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

          def result_2d6(total, dice_total, _dice_list, cmp_op, target)
        return nil unless cmp_op == :>=

        sequence = []
        result = Result.new
    Severity: Minor
    Found in lib/bcdice/game_system/ChaosFlare.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method result_2d6 has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def result_2d6(total, dice_total, _dice_list, cmp_op, target)
    Severity: Minor
    Found in lib/bcdice/game_system/ChaosFlare.rb - About 35 mins to fix

      Method roll_fate_table has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def roll_fate_table(command)
        m = /^FT(\d+)?/.match(command)
        if m[1]
          num = m[1].to_i
          if [0, 7].include?(num)
      Severity: Minor
      Found in lib/bcdice/game_system/ChaosFlare.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status