Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/Chill.rb

Summary

Maintainability
B
4 hrs
Test Coverage
A
96%

Method check_strike_rank has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def check_strike_rank(strikeRank)
        strikeRank = strikeRank.to_i

        dice = ''
        dice_add = ''
Severity: Minor
Found in lib/bcdice/game_system/Chill.rb - About 1 hr to fix

    Method roll_strike_rank_result has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def roll_strike_rank_result(string)
        debug('strike_rank begin string', string)

        wounds = 0
        sta_loss = 0
    Severity: Minor
    Found in lib/bcdice/game_system/Chill.rb - About 1 hr to fix

      Method result_1d100 has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def result_1d100(total, _dice_total, cmp_op, target)
        return nil if target == '?'
        return nil if cmp_op != :<=

        if total >= 100
      Severity: Minor
      Found in lib/bcdice/game_system/Chill.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method check_strike_rank has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def check_strike_rank(strikeRank)
        strikeRank = strikeRank.to_i

        dice = ''
        dice_add = ''
      Severity: Minor
      Found in lib/bcdice/game_system/Chill.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status