Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/Cthulhu7th_ChineseTraditional.rb

Summary

Maintainability
F
5 days
Test Coverage
F
14%

File Cthulhu7th_ChineseTraditional.rb has 279 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module BCDice
  module GameSystem
    class Cthulhu7th_ChineseTraditional < Base
      # ゲームシステムの識別子
      ID = 'Cthulhu7th:ChineseTraditional'
Severity: Minor
Found in lib/bcdice/game_system/Cthulhu7th_ChineseTraditional.rb - About 2 hrs to fix

    Class Cthulhu7th_ChineseTraditional has 21 methods (exceeds 20 allowed). Consider refactoring.
    Open

        class Cthulhu7th_ChineseTraditional < Base
      # ゲームシステムの識別子
      ID = 'Cthulhu7th:ChineseTraditional'

      # ゲームシステム名
    Severity: Minor
    Found in lib/bcdice/game_system/Cthulhu7th_ChineseTraditional.rb - About 2 hrs to fix

      Method getCheckResultText has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

            def getCheckResultText(total, diff, fumbleable = false)
        if total <= diff
          return "決定性的成功" if total == 1
          return "極限的成功" if total <= (diff / 5)
          return "困難的成功" if total <= (diff / 2)
      Severity: Minor
      Found in lib/bcdice/game_system/Cthulhu7th_ChineseTraditional.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method rollFullAuto has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def rollFullAuto(bullet_count, diff, broken_number, dice_num)
        output = ""
        loopCount = 0

        counts = {
      Severity: Minor
      Found in lib/bcdice/game_system/Cthulhu7th_ChineseTraditional.rb - About 1 hr to fix

        Method getBulletResults has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def getBulletResults(bullet_count, hit_type, diff)
        bullet_set_count = getSetOfBullet(diff)
        hit_bullet_count_base = getHitBulletCountBase(diff, bullet_set_count)
        impale_bullet_count_base = (bullet_set_count / 2.to_f)
        Severity: Minor
        Found in lib/bcdice/game_system/Cthulhu7th_ChineseTraditional.rb - About 1 hr to fix

          Method getFullAutoResult has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

                def getFullAutoResult(command)
        return nil unless /^FAR\((-?\d+)(,(-?\d+))(,(-?\d+))(,(-?\d+))?\)/i =~ command

        bullet_count = Regexp.last_match(1).to_i
        diff = Regexp.last_match(3).to_i
          Severity: Minor
          Found in lib/bcdice/game_system/Cthulhu7th_ChineseTraditional.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method rollFullAuto has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                def rollFullAuto(bullet_count, diff, broken_number, dice_num)
        output = ""
        loopCount = 0

        counts = {
          Severity: Minor
          Found in lib/bcdice/game_system/Cthulhu7th_ChineseTraditional.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method getCombineRoll has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

                def getCombineRoll(command)
        return nil unless /CBR\((\d+),(\d+)\)/i =~ command

        diff_1 = Regexp.last_match(1).to_i
        diff_2 = Regexp.last_match(2).to_i
          Severity: Minor
          Found in lib/bcdice/game_system/Cthulhu7th_ChineseTraditional.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                  return output
          Severity: Major
          Found in lib/bcdice/game_system/Cthulhu7th_ChineseTraditional.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return "失敗"
            Severity: Major
            Found in lib/bcdice/game_system/Cthulhu7th_ChineseTraditional.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return fumble_text if total == 100
              Severity: Major
              Found in lib/bcdice/game_system/Cthulhu7th_ChineseTraditional.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return fumble_text
                Severity: Major
                Found in lib/bcdice/game_system/Cthulhu7th_ChineseTraditional.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return fumble_text if fumbleable
                  Severity: Major
                  Found in lib/bcdice/game_system/Cthulhu7th_ChineseTraditional.rb - About 30 mins to fix

                    Method getBulletResults has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                          def getBulletResults(bullet_count, hit_type, diff)
        bullet_set_count = getSetOfBullet(diff)
        hit_bullet_count_base = getHitBulletCountBase(diff, bullet_set_count)
        impale_bullet_count_base = (bullet_set_count / 2.to_f)
                    Severity: Minor
                    Found in lib/bcdice/game_system/Cthulhu7th_ChineseTraditional.rb - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                      module GameSystem
    class Cthulhu7th_ChineseTraditional < Base
      # ゲームシステムの識別子
      ID = 'Cthulhu7th:ChineseTraditional'
                    Severity: Major
                    Found in lib/bcdice/game_system/Cthulhu7th_ChineseTraditional.rb and 1 other location - About 3 days to fix
                    lib/bcdice/game_system/Cthulhu7th_Korean.rb on lines 4..379

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 838.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status