Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/DivineCharger.rb

Summary

Maintainability
D
2 days
Test Coverage

File DivineCharger.rb has 790 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module BCDice
  module GameSystem
    class DivineCharger < Base
      # ゲームシステムの識別子
      ID = 'DivineCharger'
Severity: Major
Found in lib/bcdice/game_system/DivineCharger.rb - About 1 day to fix

    Method action_result has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def action_result(action)
        output = action.text
        dice = action.dice
        target = action.target
    Severity: Minor
    Found in lib/bcdice/game_system/DivineCharger.rb - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

                  return Result.failure(output)
      Severity: Major
      Found in lib/bcdice/game_system/DivineCharger.rb - About 30 mins to fix

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

                "RET" => DiceTable::D66Table.new(
          "ランダムイベント",
          D66SortType::NO_SORT,
          {
            11 => '[描写]:辺りには何もなく、がらんとした部屋だ。近くに宝箱がある。[予測]:こういう場所では運動神経を試される罠が仕掛けてあることが多い。宝箱の中には、当然ながら金目のものが眠っているはずだ。[探索時間:4]',
        Severity: Major
        Found in lib/bcdice/game_system/DivineCharger.rb and 4 other locations - About 2 hrs to fix
        lib/bcdice/game_system/Ayabito.rb on lines 94..133
        lib/bcdice/game_system/BloodMoon.rb on lines 207..246
        lib/bcdice/game_system/DarkDaysDrive.rb on lines 197..236
        lib/bcdice/game_system/Yggdrasill.rb on lines 555..599

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 79.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status