Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/EclipsePhase.rb

Summary

Maintainability
A
3 hrs
Test Coverage
A
100%

Method result_1d100 has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

      def result_1d100(total, _dice_total, cmp_op, target)
        return nil if target == '?'
        return nil unless cmp_op == :<=

        dice_value = total % 100 # 出目00は100ではなく00とする
Severity: Minor
Found in lib/bcdice/game_system/EclipsePhase.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

          return Result.critical('決定的成功') if total <= target
Severity: Major
Found in lib/bcdice/game_system/EclipsePhase.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

              return Result.fumble('決定的失敗')
    Severity: Major
    Found in lib/bcdice/game_system/EclipsePhase.rb - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status