Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/FateCoreSystem.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method roll_df has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def roll_df(command)
        parser = Command::Parser.new("DF", round_type: @round_type)
                                .enable_prefix_number()
                                .restrict_cmp_op_to(:>=, nil)
Severity: Minor
Found in lib/bcdice/game_system/FateCoreSystem.rb - About 1 hr to fix

    Method result_ladder has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def result_ladder(total)
        ladder =
          case total.clamp(-2, 8)
          when 8
            "Legendary"
    Severity: Minor
    Found in lib/bcdice/game_system/FateCoreSystem.rb - About 1 hr to fix

      Method roll_df has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def roll_df(command)
        parser = Command::Parser.new("DF", round_type: @round_type)
                                .enable_prefix_number()
                                .restrict_cmp_op_to(:>=, nil)
      Severity: Minor
      Found in lib/bcdice/game_system/FateCoreSystem.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status