Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/GURPS.rb

Summary

Maintainability
B
5 hrs
Test Coverage
A
98%

File GURPS.rb has 321 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module BCDice
  module GameSystem
    class GURPS < Base
      # ゲームシステムの識別子
      ID = 'GURPS'
Severity: Minor
Found in lib/bcdice/game_system/GURPS.rb - About 3 hrs to fix

    Method result_nd6 has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

          def result_nd6(total, dice_total, dice_list, cmp_op, target)
        return nil if target == "?"
        return nil unless dice_list.size == 3 && cmp_op == :<=

        success = target - total # 成功度
    Severity: Minor
    Found in lib/bcdice/game_system/GURPS.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method result_nd6 has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def result_nd6(total, dice_total, dice_list, cmp_op, target)
    Severity: Minor
    Found in lib/bcdice/game_system/GURPS.rb - About 35 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              '1ターン朦朧状態。2ターン目に自動回復。',
        '1ターン朦朧状態。2ターン目に自動回復。',
        '1ターン朦朧状態。以後、毎ターン不利な修正を無視した意志判定を行い、成功すると回復。',
        '1ターン朦朧状態。以後、毎ターン不利な修正を無視した意志判定を行い、成功すると回復。',
        '1ターン朦朧状態。以後、毎ターン通常の意志判定を行い、成功すると回復。',
      Severity: Minor
      Found in lib/bcdice/game_system/GURPS.rb and 1 other location - About 40 mins to fix
      lib/bcdice/game_system/GurpsFW.rb on lines 236..272

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 38.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status