bcdice/BCDice

View on GitHub
lib/bcdice/game_system/GardenOrder.rb

Summary

Maintainability
B
6 hrs
Test Coverage
A
100%

File GardenOrder.rb has 420 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module BCDice
  module GameSystem
    class GardenOrder < Base
      # ゲームシステムのの識別子
      ID = 'GardenOrder'
Severity: Minor
Found in lib/bcdice/game_system/GardenOrder.rb - About 6 hrs to fix

    Similar blocks of code found in 6 locations. Consider refactoring.
    Invalid

            "IM" => {
              name: "衝撃",
              table: [
                [5,
                 {name: "打撲",
    Severity: Major
    Found in lib/bcdice/game_system/GardenOrder.rb and 5 other locations - About 3 hrs to fix
    lib/bcdice/game_system/GardenOrder.rb on lines 106..162
    lib/bcdice/game_system/GardenOrder.rb on lines 164..220
    lib/bcdice/game_system/GardenOrder.rb on lines 280..336
    lib/bcdice/game_system/GardenOrder.rb on lines 338..394
    lib/bcdice/game_system/GardenOrder.rb on lines 396..452

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 122.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Invalid

            "SL" => {
              name: "切断",
              table: [
                [5,
                 {name: "切り傷",
    Severity: Major
    Found in lib/bcdice/game_system/GardenOrder.rb and 5 other locations - About 3 hrs to fix
    lib/bcdice/game_system/GardenOrder.rb on lines 164..220
    lib/bcdice/game_system/GardenOrder.rb on lines 222..278
    lib/bcdice/game_system/GardenOrder.rb on lines 280..336
    lib/bcdice/game_system/GardenOrder.rb on lines 338..394
    lib/bcdice/game_system/GardenOrder.rb on lines 396..452

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 122.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Invalid

            "EL" => {
              name: "電撃",
              table: [
                [5,
                 {name: "静電気",
    Severity: Major
    Found in lib/bcdice/game_system/GardenOrder.rb and 5 other locations - About 3 hrs to fix
    lib/bcdice/game_system/GardenOrder.rb on lines 106..162
    lib/bcdice/game_system/GardenOrder.rb on lines 164..220
    lib/bcdice/game_system/GardenOrder.rb on lines 222..278
    lib/bcdice/game_system/GardenOrder.rb on lines 280..336
    lib/bcdice/game_system/GardenOrder.rb on lines 338..394

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 122.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Invalid

            "RF" => {
              name: "冷却",
              table: [
                [5,
                 {name: "冷気",
    Severity: Major
    Found in lib/bcdice/game_system/GardenOrder.rb and 5 other locations - About 3 hrs to fix
    lib/bcdice/game_system/GardenOrder.rb on lines 106..162
    lib/bcdice/game_system/GardenOrder.rb on lines 164..220
    lib/bcdice/game_system/GardenOrder.rb on lines 222..278
    lib/bcdice/game_system/GardenOrder.rb on lines 280..336
    lib/bcdice/game_system/GardenOrder.rb on lines 396..452

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 122.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Invalid

            "BR" => {
              name: "灼熱",
              table: [
                [5,
                 {name: "火傷",
    Severity: Major
    Found in lib/bcdice/game_system/GardenOrder.rb and 5 other locations - About 3 hrs to fix
    lib/bcdice/game_system/GardenOrder.rb on lines 106..162
    lib/bcdice/game_system/GardenOrder.rb on lines 164..220
    lib/bcdice/game_system/GardenOrder.rb on lines 222..278
    lib/bcdice/game_system/GardenOrder.rb on lines 338..394
    lib/bcdice/game_system/GardenOrder.rb on lines 396..452

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 122.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Invalid

            "BL" => {
              name: "銃弾",
              table: [
                [5,
                 {name: "腕部損傷",
    Severity: Major
    Found in lib/bcdice/game_system/GardenOrder.rb and 5 other locations - About 3 hrs to fix
    lib/bcdice/game_system/GardenOrder.rb on lines 106..162
    lib/bcdice/game_system/GardenOrder.rb on lines 222..278
    lib/bcdice/game_system/GardenOrder.rb on lines 280..336
    lib/bcdice/game_system/GardenOrder.rb on lines 338..394
    lib/bcdice/game_system/GardenOrder.rb on lines 396..452

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 122.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Invalid

          def eval_game_system_specific_command(command)
            case command
            when %r{GO(-?\d+)(/(\d+))?(@(\d+))?}i
              success_rate = Regexp.last_match(1).to_i
              repeat_count = (Regexp.last_match(3) || 1).to_i
    Severity: Major
    Found in lib/bcdice/game_system/GardenOrder.rb and 1 other location - About 1 hr to fix
    lib/bcdice/game_system/AceKillerGene.rb on lines 35..51

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status