Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/GoblinSlayer.rb

Summary

Maintainability
B
4 hrs
Test Coverage
A
97%

Method getCheckResult has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def getCheckResult(command)
        m = /^GS([-+]?\d+)?(?:(?:([@#])([-+]?\d+))(?:([@#])([-+]?\d+))?)?(?:(>=?)(\d+))?$/i.match(command)
        unless m
          return nil
        end
Severity: Minor
Found in lib/bcdice/game_system/GoblinSlayer.rb - About 1 hr to fix

    Method resultStr has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

          def resultStr(achievement, target, cmp_op, fumble, critical)
        return '大失敗' if fumble
        return '大成功' if critical
        if cmp_op == ">="
          return achievement >= target ? "成功" : "失敗"
    Severity: Minor
    Found in lib/bcdice/game_system/GoblinSlayer.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getCheckResult has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def getCheckResult(command)
        m = /^GS([-+]?\d+)?(?:(?:([@#])([-+]?\d+))(?:([@#])([-+]?\d+))?)?(?:(>=?)(\d+))?$/i.match(command)
        unless m
          return nil
        end
    Severity: Minor
    Found in lib/bcdice/game_system/GoblinSlayer.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method damageBonus has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def damageBonus(command)
        m = /^DB(\d+)$/i.match(command)
        unless m
          return nil
        end
    Severity: Minor
    Found in lib/bcdice/game_system/GoblinSlayer.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method resultStr has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def resultStr(achievement, target, cmp_op, fumble, critical)
    Severity: Minor
    Found in lib/bcdice/game_system/GoblinSlayer.rb - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status