Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/GranCrest.rb

Summary

Maintainability
B
4 hrs
Test Coverage
A
97%

File GranCrest.rb has 267 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module BCDice
  module GameSystem
    class GranCrest < Base
      # ゲームシステムの識別子
      ID = 'GranCrest'
Severity: Minor
Found in lib/bcdice/game_system/GranCrest.rb - About 2 hrs to fix

    Method result_nd6 has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def result_nd6(total, _dice_total, dice_list, cmp_op, target)
        return nil unless cmp_op == :>=

        result = Result.new
        sequence = []
    Severity: Minor
    Found in lib/bcdice/game_system/GranCrest.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method result_nd6 has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def result_nd6(total, _dice_total, dice_list, cmp_op, target)
    Severity: Minor
    Found in lib/bcdice/game_system/GranCrest.rb - About 35 mins to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              "MT" => DiceTable::D66OneThirdTable.new(
          "邂逅表",
          [
            "師匠\nあなたは彼（彼女）から多くのものを学んだ。あなたにとって、彼（彼女）は師であった。",
            "保護者\nあなたは彼（彼女）を兄や姉、あるいは父親のように慕っている。もちろん本当に血縁関係があってもよい。",
      Severity: Minor
      Found in lib/bcdice/game_system/GranCrest.rb and 2 other locations - About 15 mins to fix
      lib/bcdice/game_system/GranCrest.rb on lines 98..123
      lib/bcdice/game_system/GranCrest.rb on lines 125..150

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              "NFT" => DiceTable::D66OneThirdTable.new(
          "ネガティブ感情表",
          [
            "憤憑\nあなたは彼（彼女）に憤憑を覚えている。性格か、その癖か、何かにあなたは怒りを覚えているのだ。",
            "悲哀\nあなたは彼（彼女）に悲哀を感じている。その過去か、それとも別のものか、あなたは彼（彼女）をかわいそうだと感じている。",
      Severity: Minor
      Found in lib/bcdice/game_system/GranCrest.rb and 2 other locations - About 15 mins to fix
      lib/bcdice/game_system/GranCrest.rb on lines 71..96
      lib/bcdice/game_system/GranCrest.rb on lines 98..123

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              "PFT" => DiceTable::D66OneThirdTable.new(
          "ポジティブ感情表",
          [
            "好奇心\nあなたは彼（彼女）に好奇心を感じた。彼（彼女）はとても面白い。もっと知ってみたいと感じた。",
            "憧憬\nあなたは彼（彼女）にあこがれを感じた。彼（彼女）のようになりたいと思った。その思いは今でも続いている。",
      Severity: Minor
      Found in lib/bcdice/game_system/GranCrest.rb and 2 other locations - About 15 mins to fix
      lib/bcdice/game_system/GranCrest.rb on lines 71..96
      lib/bcdice/game_system/GranCrest.rb on lines 125..150

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status