Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/Insane.rb

Summary

Maintainability
A
3 hrs
Test Coverage
A
100%

Method get_interim_reference_number has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def get_interim_reference_number
        table = [
          [11, '1'],
          [12, '2'],
          [13, '3'],
Severity: Minor
Found in lib/bcdice/game_system/Insane.rb - About 1 hr to fix

    Method translate_tables has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def translate_tables(locale)
          {
            "ST" => DiceTable::Table.from_i18n("Insane.table.ST", locale),
            "HJST" => DiceTable::Table.from_i18n("Insane.table.HJST", locale),
            "MTST" => DiceTable::Table.from_i18n("Insane.table.MTST", locale),
    Severity: Minor
    Found in lib/bcdice/game_system/Insane.rb - About 1 hr to fix

      Method result_2d6 has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def result_2d6(total, dice_total, _dice_list, cmp_op, target)
      Severity: Minor
      Found in lib/bcdice/game_system/Insane.rb - About 35 mins to fix

        Method result_2d6 has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

              def result_2d6(total, dice_total, _dice_list, cmp_op, target)
        return nil unless cmp_op == :>=

        if dice_total <= 2
          Result.fumble(translate("Insane.fumble"))
        Severity: Minor
        Found in lib/bcdice/game_system/Insane.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status