Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/LostRoyal.rb

Summary

Maintainability
B
5 hrs
Test Coverage
A
100%

Method roll_wind_power_chart has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def roll_wind_power_chart
        key = 0
        total_bonus = 0
        text = ""
Severity: Minor
Found in lib/bcdice/game_system/LostRoyal.rb - About 1 hr to fix

    Method check_lostroyal has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

          def check_lostroyal(checking_table)
        keys = []

        3.times do |_i|
          key = @randomizer.roll_once(6)
    Severity: Minor
    Found in lib/bcdice/game_system/LostRoyal.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method roll_hope has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

          def roll_hope(number_of_dice)
        total = 0
        text = ""

        loop do
    Severity: Minor
    Found in lib/bcdice/game_system/LostRoyal.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method roll_wind_power_chart has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

          def roll_wind_power_chart
        key = 0
        total_bonus = 0
        text = ""
    Severity: Minor
    Found in lib/bcdice/game_system/LostRoyal.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return nil
    Severity: Major
    Found in lib/bcdice/game_system/LostRoyal.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                return roll_hope(Regexp.last_match(1).to_i)
      Severity: Major
      Found in lib/bcdice/game_system/LostRoyal.rb - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              def roll_emotion_chart
        key = @randomizer.roll_once(6)

        text = [
          "愛情／殺意",
        Severity: Minor
        Found in lib/bcdice/game_system/LostRoyal.rb and 1 other location - About 15 mins to fix
        lib/bcdice/game_system/LostRoyal.rb on lines 135..147

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              def roll_fumble_chart
        key = @randomizer.roll_once(6)

        text = [
          "何かの問題で言い争い、主君に無礼を働いてしまう。あなたは主君の名誉点を１点失うか、【時間】を１点消費して和解の話し合いを持つか選べる。",
        Severity: Minor
        Found in lib/bcdice/game_system/LostRoyal.rb and 1 other location - About 15 mins to fix
        lib/bcdice/game_system/LostRoyal.rb on lines 190..202

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status