Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/Paradiso.rb

Summary

Maintainability
D
1 day
Test Coverage
D
61%

File Paradiso.rb has 275 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module BCDice
  module GameSystem
    class Paradiso < Base
      # ゲームシステムの識別子
      ID = 'Paradiso'
Severity: Minor
Found in lib/bcdice/game_system/Paradiso.rb - About 2 hrs to fix

    Method getDamageResult has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def getDamageResult(command)
        biggun = [0, 0, 0]

        case command
        when /^DC(\d+)(\[(\d+)(,(\d+))?(,(\d+))?(,(\d+))?(,(\d+))?(,(\d+))?\])?$/i
    Severity: Minor
    Found in lib/bcdice/game_system/Paradiso.rb - About 1 hr to fix

      Method getJudgeResult has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def getJudgeResult(command)
        case command
        when /^(\d+)?D20<=(\d+)?(\[(\d+)(,(\d+))?\])?(@(\d+))?$/i
          number = (Regexp.last_match(1) || 1).to_i # ダイス数。省略時は1
          target = (Regexp.last_match(2) || 14).to_i # 目標値。省略時は14  if 空白 then 14 else 記載の値
      Severity: Minor
      Found in lib/bcdice/game_system/Paradiso.rb - About 1 hr to fix

        Method getJudgeResult has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

              def getJudgeResult(command)
        case command
        when /^(\d+)?D20<=(\d+)?(\[(\d+)(,(\d+))?\])?(@(\d+))?$/i
          number = (Regexp.last_match(1) || 1).to_i # ダイス数。省略時は1
          target = (Regexp.last_match(2) || 14).to_i # 目標値。省略時は14  if 空白 then 14 else 記載の値
        Severity: Minor
        Found in lib/bcdice/game_system/Paradiso.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method get_takeoff_table has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def get_takeoff_table
        dice = @randomizer.roll_once(20)
        case dice
        when 1
          text = "エンジンがぶっ壊れた！ただちに【機体コンディション】が「20」となり、このターン中は2つ目のアクションも含め「●移動」することができない。"
        Severity: Minor
        Found in lib/bcdice/game_system/Paradiso.rb - About 1 hr to fix

          Method get_flightsupply_table has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def get_flightsupply_table
        dice = @randomizer.roll_once(20)
        case dice
        when 1
          text = "……えっ？！　キミの【物資点】は0点となる。"
          Severity: Minor
          Found in lib/bcdice/game_system/Paradiso.rb - About 1 hr to fix

            Method get_exploration_table has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  def get_exploration_table
        dice = @randomizer.roll_once(20)
        case dice
        when 1
          text = "クソっ！このマスに付与されていた\[手がかり\]を失う。"
            Severity: Minor
            Found in lib/bcdice/game_system/Paradiso.rb - About 1 hr to fix

              Method getDamageResult has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                    def getDamageResult(command)
        biggun = [0, 0, 0]

        case command
        when /^DC(\d+)(\[(\d+)(,(\d+))?(,(\d+))?(,(\d+))?(,(\d+))?(,(\d+))?\])?$/i
              Severity: Minor
              Found in lib/bcdice/game_system/Paradiso.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method eval_game_system_specific_command has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                    def eval_game_system_specific_command(command) # ダイスロールコマンド
        # 通常判定部分をgetJudgeResultコマンドに切り分け
        result = getJudgeResult(command)
        return result unless result.nil?
              Severity: Minor
              Found in lib/bcdice/game_system/Paradiso.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      when /^(\d+)?D20<=(\d+)?(\[(\d+)(,(\d+))?\])?(@(\d+))?$/i
          number = (Regexp.last_match(1) || 1).to_i # ダイス数。省略時は1
          target = (Regexp.last_match(2) || 14).to_i # 目標値。省略時は14  if 空白 then 14 else 記載の値
          fumble1 = (Regexp.last_match(4) || 21).to_i # 追加ファンブル値。省略時は21
          fumble2 = (Regexp.last_match(6) || 21).to_i # 追加ファンブル値。省略時は21
              Severity: Major
              Found in lib/bcdice/game_system/Paradiso.rb and 2 other locations - About 40 mins to fix
              lib/bcdice/game_system/Paradiso.rb on lines 62..67
              lib/bcdice/game_system/StellarLife.rb on lines 55..60

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 38.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      when /^(\d+)?CP(\d+)?(\[(\d+)(,(\d+))?\])?(@(\d+))?$/i
          number = (Regexp.last_match(1) || 1).to_i
          target = (Regexp.last_match(2) || 14).to_i
          fumble1 = (Regexp.last_match(4) || 21).to_i
          fumble2 = (Regexp.last_match(6) || 21).to_i
              Severity: Major
              Found in lib/bcdice/game_system/Paradiso.rb and 2 other locations - About 40 mins to fix
              lib/bcdice/game_system/Paradiso.rb on lines 56..61
              lib/bcdice/game_system/StellarLife.rb on lines 55..60

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 38.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status